Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed geokit-rails from Gemfile and Gemfile.lock as requested #6168

Closed
wants to merge 3 commits into from

Conversation

Akter8
Copy link

@Akter8 Akter8 commented Aug 20, 2019

Fixes #6165(<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Aug 20, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@Akter8 Akter8 closed this Aug 20, 2019
@Akter8 Akter8 reopened this Aug 20, 2019
@Akter8 Akter8 closed this Aug 20, 2019
@grvsachdeva grvsachdeva reopened this Aug 21, 2019
@grvsachdeva
Copy link
Member

After removing gem from Gemfile, run bundle install so that changes are made in Gemfile.lock accordingly.

@grvsachdeva
Copy link
Member

We are using geokit-rails here - https://github.com/publiclab/plots2/blob/master/app/models/drupal_content_type_map.rb#L9, that's why tests are failing. @jywarren do we use this model anymore?

@grvsachdeva
Copy link
Member

@jywarren can you please verify the usage of this model??

@jywarren
Copy link
Member

Aha - sorry for delay - we have a plan to convert all of those into notes: #4072

If we complete that, we should be OK here -- but, do we use GeoKit to display maps on this page? https://publiclab.org/maps

I don't think so?

https://github.com/publiclab/plots2/blob/master/app/controllers/map_controller.rb

https://github.com/publiclab/plots2/blob/master/app/views/map/index.html.erb

https://github.com/publiclab/plots2/blob/master/app/views/map/show.html.erb

@SidharthBansal
Copy link
Member

As the person is inactive for more than a month, I am closing the PR. In case you want to push changes please feel free to open a new PR OR reopen this PR and add additional changes to it.
Thanks for contributing on Public Lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove geokit-rails gem from the project
4 participants