Modified views for Q & A Pages #628

ananyo2012 · 2016-07-23T02:21:28Z

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

tests pass -- rake test
code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
pull request are descriptively named
if possible, multiple commits squashed if they're smaller changes
reviewed/confirmed/tested by another contributor or maintainer
development.sqlite.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

ananyo2012 · 2016-07-23T02:28:01Z

This is the Recently answered view for the questions index page

ananyo2012 · 2016-07-23T02:32:31Z

app/models/drupal_users.rb

@@ -66,11 +66,11 @@ def like_count
  end

  def liked_notes
-    DrupalNode.includes(:node_selections).where("type = 'note' AND node_selections.liking = true AND node_selections.user_id = ? AND node.status = 1", self.uid).order('node_selections.nid DESC')
+    DrupalNode.includes(:node_selections).where("type = 'note' AND node_selections.liking = ? AND node_selections.user_id = ? AND node.status = 1", true, self.uid).order('node_selections.nid DESC')


Had to make this change because the sqlite db was showing an error probably because it wasn't taking true as a boolean. So the likes page was'nt rendering when using the sqlite db.

perfect, good catch.

ananyo2012 · 2016-07-23T03:44:53Z

app/views/questions/_questions.html.erb

@@ -18,7 +18,7 @@
        <% end %>
        </span>
        <p style="margin-top:30px;"><% if logged_in_as(['admin','moderator']) %><a class="btn btn-default btn-xs" href="/moderate/spam/<%= node.id %>"><i class="fa fa-ban"></i> Spam</a><% end %>
-        <a href="#" class="btn btn-default btn-xs">Post an answer</a></p>
+        <a href="<%= node.path(:question) %>#post-answer" class="btn btn-default btn-xs">Post an answer</a></p>


Wierd! the Post an answer link that I added was somehow reverted in any previous changes. I added it back. Nevertheless it previously wan't correct so I put the correct one this time.

ananyo2012 · 2016-07-24T05:13:44Z

app/controllers/questions_search_controller.rb

-      link = "<span class='pull-left'><i data-url='" + match.path(:question) + 
-             "' class='fa fa-question-circle'></i> " + match.title + "</span>"
+      link = "<i data-url='" + match.path(:question) + 
+             "' class='fa fa-question-circle'></i> " + match.title


This fixes the problem of dropdown link in the questions search box which is not working currently.

ananyo2012 · 2016-07-27T15:32:29Z

Also includes commits from #636.

jywarren · 2016-07-28T16:39:14Z

what if:

Answered questions were clearly marked as Answered (maybe with the same green indicator used on the Answer?)
Profiles just had an "Questions" tab, then two sections below for Answered and Asked?

ananyo2012 · 2016-07-28T16:42:52Z

Yeah it's a good idea Jeff. I will work on it. I was thinking of the
listing the answers in the profile page too. So should we list the quoted
answer somewhere near the questions for the Answered section?
ᐧ

On Thu, Jul 28, 2016 at 10:09 PM, Jeffrey Warren notifications@github.com
wrote:

what if:

Answered questions were clearly marked as Answered (maybe with the
same green indicator used on the Answer?)
2.

Profiles just had an "Questions" tab, then two sections below for
Answered and Asked?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKACR2fApXECw4dCcz1ALjQ5YFxJhJifks5qaNs0gaJpZM4JTQnt
.

jywarren · 2016-07-28T16:46:54Z

Hmm, that would be a lot to show; maybe we could just say "Answered by
username" or "6 proposed answers" ?

On Thu, Jul 28, 2016 at 12:42 PM, Ananya Maiti notifications@github.com
wrote:

Yeah it's a good idea Jeff. I will work on it. I was thinking of the
listing the answers in the profile page too. So should we list the quoted
answer somewhere near the questions for the Answered section?
ᐧ

On Thu, Jul 28, 2016 at 10:09 PM, Jeffrey Warren <notifications@github.com

wrote:

what if:

Answered questions were clearly marked as Answered (maybe with the
same green indicator used on the Answer?)
2.

Profiles just had an "Questions" tab, then two sections below for
Answered and Asked?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AKACR2fApXECw4dCcz1ALjQ5YFxJhJifks5qaNs0gaJpZM4JTQnt

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJyF2F92HIfHAA_YQSGaS9F7DQcfBks5qaNwMgaJpZM4JTQnt
.

ananyo2012 · 2016-07-28T16:48:55Z

Yes that's a better idea; just linking the answer with a text.
ᐧ

On Thu, Jul 28, 2016 at 10:16 PM, Jeffrey Warren notifications@github.com
wrote:

Hmm, that would be a lot to show; maybe we could just say "Answered by
username" or "6 proposed answers" ?

On Thu, Jul 28, 2016 at 12:42 PM, Ananya Maiti notifications@github.com
wrote:

Yeah it's a good idea Jeff. I will work on it. I was thinking of the
listing the answers in the profile page too. So should we list the quoted
answer somewhere near the questions for the Answered section?
ᐧ

On Thu, Jul 28, 2016 at 10:09 PM, Jeffrey Warren <
notifications@github.com

wrote:

what if:

Answered questions were clearly marked as Answered (maybe with the
same green indicator used on the Answer?)
2.

Profiles just had an "Questions" tab, then two sections below for
Answered and Asked?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute
the thread
<

https://github.com/notifications/unsubscribe-auth/AKACR2fApXECw4dCcz1ALjQ5YFxJhJifks5qaNs0gaJpZM4JTQnt

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment),
or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AABfJyF2F92HIfHAA_YQSGaS9F7DQcfBks5qaNwMgaJpZM4JTQnt

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKACRw9IXqNtYR_9E9DpahAmuPdeFIkQks5qaNz_gaJpZM4JTQnt
.

jywarren · 2016-07-29T17:52:46Z

Shall I merge this now, or do you want to keep working on it? (or in another PR later?)

ananyo2012 · 2016-07-29T18:33:41Z

@jywarren Please wait till I complete all the features.

ananyo2012 · 2016-07-29T18:34:13Z

Probably it will be ready for merge by Tuesday.

jywarren · 2016-07-29T18:39:51Z

Perfect, no problem.

On Jul 29, 2016 2:34 PM, "Ananya Maiti" notifications@github.com wrote:

Probably it will be ready for merge by Tuesday.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJ4m81rQiPLA9MrsT9jbMt3HWT2-Nks5qakelgaJpZM4JTQnt
.

ananyo2012 · 2016-08-02T09:35:26Z

@jywarren Just some clarifications on what you asked

Answered questions were clearly marked as Answered (maybe with the same green indicator used on the Answer?)

When will a question marked as answered? When there is atleast one answer or when it is marked as accepted by the question author?

jywarren · 2016-08-02T18:04:30Z

When an answer is accepted. Thanks!

ananyo2012 · 2016-08-06T03:34:44Z

@jywarren This is almost complete. Just need to add some more tests. You can review it in the mean time. I am posting the screenshots for the modified views below.

ananyo2012 · 2016-08-06T03:56:44Z

I have already posted a screenshot of the recently answered view. Link to the question page is added in the navbar under the Projects tab. The question links in dashboard now link to the new question views. Also the Ask question links in the Dashborad and tags page link to the question post page now.

jywarren · 2016-08-14T14:53:27Z

It doesn't look like we have a test for admin (as opposed to a moderator) approving a first-timer post. I've added one and it seems to pass, so I'm not sure what's up. Maybe we should add one for approving a first-timer question, not a normal note.

ananyo2012 · 2016-08-14T14:54:13Z

@jywarren Updated and rebased on the latest master. Here is the screenshot

jywarren · 2016-08-14T14:57:28Z

Oh, i'm sorry, i meant green outlining of the Accepted badge, not the answers by user. Answers by user looks perfect, just needs the same color as the (?) icon -- not light green.Accepted` could be green borders with transparent interior, and on its own line.

Looking great on spacing, though!

ananyo2012 · 2016-08-14T15:00:31Z

@jywarren Ok updating it. I am also trying to look at the issue you mentioned. It looks like I have missed something for the first timer questions.

jywarren · 2016-08-14T15:01:37Z

Ok, good luck! I am about to board a plane so won't be checking in again
today. Thanks as usual!

On Aug 14, 2016 3:00 PM, "Ananya Maiti" notifications@github.com wrote:

@jywarren https://github.com/jywarren Ok updating it. I am also trying
to look at the issue you mentioned. It looks like I have missed something
for the first timer questions.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_vxtUCieVxoCaQ2Zxu3lPrfxmG2ks5qfy2PgaJpZM4JTQnt
.

ananyo2012 · 2016-08-14T15:24:39Z

@jywarren Yes it is really looking great this way now.

ananyo2012 · 2016-08-14T20:42:05Z

@jywarren First timer questions are now visible to admins in the questions index page. I have also modified the tests to justify it. Also flash messages are displayed while approving the first timer questions through proper redirects. Also added test for admin controller to support it.

Mark question as answered when an answer is accepted

Modify sort_questions_by_tag method to improve efficiency

Link tags in questions to 'question' tag views

Add post path to question from submit action Use javascript submit only for input field on submit to question search

Add integration test for question sort feature Fix failing tests caused due to the changes

Redirect question to question path while publishing first-timer-questions Add functional test for admin controller

ananyo2012 · 2016-08-14T21:23:02Z

I have also changed the Answered label in the questions view similar to that in the profile answered views.

jywarren · 2016-08-15T13:48:29Z

Great, i'll do final review and merge tomorrow. Great work!

On Sun, Aug 14, 2016 at 10:23 PM, Ananya Maiti notifications@github.com
wrote:

I have also changed the Answered label in the questions view similar to
that in the profile answered views.
[image: profile_asked_v2 1]
https://cloud.githubusercontent.com/assets/10486343/17652176/5df9974c-6293-11e6-9094-87e6cc3225de.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABfJ-HYo0Bq05zSmCRzDkKajLwy38iJks5qf4c4gaJpZM4JTQnt
.

jywarren · 2016-08-16T22:12:50Z

💯 merged!! I made some small final style tweaks, and hope to publish tonight. GREAT WORK, ananyo! Reach out to Liz and Stevie and ask them to help you test it out once it's published. I'll alert you.

ananyo2012 · 2016-08-16T22:16:48Z

Thanks Jeff! I was thining of adding some documentation for Q & A in the
same PR. Anyways I will make a new one for it.
ᐧ

On Wed, Aug 17, 2016 at 3:42 AM, Jeffrey Warren notifications@github.com
wrote:

💯 merged!! I made some small final style tweaks, and hope to publish
tonight. GREAT WORK, ananyo! Reach out to Liz and Stevie and ask them to
help you test it out once it's published. I'll alert you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#628 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKACR4_hAx8FF2aqtvL7SndIPgQv8r_Dks5qgjXjgaJpZM4JTQnt
.

* Remove outdated query as code in #628 no longer used, fixes #9571 * Update _question.html.erb

…lab#9572) * Remove outdated query as code in publiclab#628 no longer used, fixes publiclab#9571 * Update _question.html.erb

ananyo2012 reviewed Jul 23, 2016
View reviewed changes

ananyo2012 force-pushed the q_and_a_views branch 2 times, most recently from a3c21ea to 98e696f Compare July 23, 2016 03:39

ananyo2012 reviewed Jul 23, 2016
View reviewed changes

ananyo2012 force-pushed the q_and_a_views branch from 98e696f to a1a99c3 Compare July 23, 2016 03:49

ananyo2012 reviewed Jul 24, 2016
View reviewed changes

ananyo2012 force-pushed the q_and_a_views branch 2 times, most recently from 365a770 to 272954e Compare July 27, 2016 15:30

This was referenced Jul 27, 2016

Add question links to navbar and dashboard questions #636

Closed

Missing template : "home/comments" #637

Closed

ananyo2012 force-pushed the q_and_a_views branch from 272954e to fc14dd5 Compare July 27, 2016 18:14

ananyo2012 force-pushed the q_and_a_views branch from fc14dd5 to 929d9bd Compare August 1, 2016 21:44

ananyo2012 force-pushed the q_and_a_views branch from 929d9bd to b505b6b Compare August 2, 2016 09:37

ananyo2012 force-pushed the q_and_a_views branch from b505b6b to 8aabf46 Compare August 3, 2016 17:00

Add tag based sorting functionality for questions index page

77d0b2c

ananyo2012 force-pushed the q_and_a_views branch from fc4f8dc to ff19bf0 Compare August 14, 2016 14:50

ananyo2012 force-pushed the q_and_a_views branch from ff19bf0 to 38a436e Compare August 14, 2016 15:22

ananyo2012 added 6 commits August 15, 2016 02:50

Add Asked and Answered views for Question tab in User Profile page

05653d1

Mark question as answered when an answer is accepted

Add questions method for drupal_node model

2345c9c

Modify sort_questions_by_tag method to improve efficiency

Add question views in tags page

153b26c

Link tags in questions to 'question' tag views

Modify question search format and view

68ba825

Add post path to question from submit action Use javascript submit only for input field on submit to question search

Add tests for relevant changes

1d6a5ce

Add integration test for question sort feature Fix failing tests caused due to the changes

List first-timer-questions in questions index page

dbc1717

Redirect question to question path while publishing first-timer-questions Add functional test for admin controller

ananyo2012 force-pushed the q_and_a_views branch from 1bfa77b to dbc1717 Compare August 14, 2016 21:20

jywarren merged commit dbc1717 into publiclab:master Aug 16, 2016

ananyo2012 deleted the q_and_a_views branch August 16, 2016 22:40

ananyo2012 mentioned this pull request Aug 17, 2016

Design process for /questions page #554

Closed

ananyo2012 modified the milestone: Q & A Project Aug 22, 2016

jywarren added a commit that referenced this pull request Apr 27, 2021

Remove outdated query as code in #628 no longer used, fixes #9571

7ec58cf

jywarren added a commit that referenced this pull request Apr 27, 2021

Remove outdated query as code in #628 no longer used (#9572)

87b776f

* Remove outdated query as code in #628 no longer used, fixes #9571 * Update _question.html.erb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modified views for Q & A Pages #628

Modified views for Q & A Pages #628

ananyo2012 commented Jul 23, 2016 •

edited

Loading

ananyo2012 commented Jul 23, 2016

ananyo2012 Jul 23, 2016 •

edited

Loading

jywarren Jul 28, 2016

ananyo2012 Jul 23, 2016

ananyo2012 Jul 24, 2016

ananyo2012 commented Jul 27, 2016

jywarren commented Jul 28, 2016

ananyo2012 commented Jul 28, 2016

jywarren commented Jul 28, 2016

ananyo2012 commented Jul 28, 2016

jywarren commented Jul 29, 2016

ananyo2012 commented Jul 29, 2016

ananyo2012 commented Jul 29, 2016

jywarren commented Jul 29, 2016

ananyo2012 commented Aug 2, 2016 •

edited

Loading

jywarren commented Aug 2, 2016

ananyo2012 commented Aug 6, 2016

ananyo2012 commented Aug 6, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 15, 2016

jywarren commented Aug 16, 2016

ananyo2012 commented Aug 16, 2016

Modified views for Q & A Pages #628

Modified views for Q & A Pages #628

Conversation

ananyo2012 commented Jul 23, 2016 • edited Loading

ananyo2012 commented Jul 23, 2016

ananyo2012 Jul 23, 2016 • edited Loading

Choose a reason for hiding this comment

jywarren Jul 28, 2016

Choose a reason for hiding this comment

ananyo2012 Jul 23, 2016

Choose a reason for hiding this comment

ananyo2012 Jul 24, 2016

Choose a reason for hiding this comment

ananyo2012 commented Jul 27, 2016

jywarren commented Jul 28, 2016

ananyo2012 commented Jul 28, 2016

jywarren commented Jul 28, 2016

ananyo2012 commented Jul 28, 2016

jywarren commented Jul 29, 2016

ananyo2012 commented Jul 29, 2016

ananyo2012 commented Jul 29, 2016

jywarren commented Jul 29, 2016

ananyo2012 commented Aug 2, 2016 • edited Loading

jywarren commented Aug 2, 2016

ananyo2012 commented Aug 6, 2016

ananyo2012 commented Aug 6, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

ananyo2012 commented Aug 14, 2016

jywarren commented Aug 15, 2016

jywarren commented Aug 16, 2016

ananyo2012 commented Aug 16, 2016

ananyo2012 commented Jul 23, 2016 •

edited

Loading

ananyo2012 Jul 23, 2016 •

edited

Loading

ananyo2012 commented Aug 2, 2016 •

edited

Loading