-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update revisions.html.erb to update translation helpers #6672
Conversation
Oh, goodness... @stefanosu you've opened something like 50 pull requests! wow a lot of hard work we appreciate your help I think they are related to @nstjean's translation helper changes -- maybe @stefanosu went down the whole list? What shall we do? I want to be sure these changes don't overwrite another contributor's work @stefanosu would you be willing to close all your PRs and consider submitting them as one PR? |
Hi, after some discussion we'd like to ask you to focus on just one instance of this -- and can you link back to the issue it came from? @nstjean maybe you can help with the link. Let's get this PR ready to merge and we can close the others, as we are hoping to use them to help welcome in other contributors. I hope you understand, and know that we appreciate your contribution! Thank you! |
Here is the link!: #6579 |
Hi @jywarren sorry for this mishap on that I thought I was referencing the issue correctly on each individual pr. Yea I did go down the whole list sorry for that. Yes, I could be able to do that. Sure of course no problem I understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good..@stefanosu could you please add a screenshot? Thanks
thanks, I'll add the screenshot but I'm having trouble running the server. I'm getting this error:
|
@stefanosu Can you please post your problem in this thread about installing plots2? #3840 It looks like it's not connecting to the mysql database on startup. |
Hey @stefanosu, You can try using sqlite3 for development if mysql is giving you a headache. You can replace your
Then run |
@cesswairimu Thanks that worked got the server up and running! |
awesome 🎉 |
This looks super and I'm merging it now! Great work! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #6740
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!