#7598

[Medlineme4]

Button tag

Fixes #7558 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[Medlineme4]

I hope I got it.

[codecov]

Codecov Report

Merging #7598 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7598      +/-   ##
==========================================
+ Coverage   81.90%   82.03%   +0.12%     
==========================================
  Files          97       97              
  Lines        5615     5615              
==========================================
+ Hits         4599     4606       +7     
+ Misses       1016     1009       -7     

Impacted Files	Coverage Δ
app/api/srch/search.rb	69.28% <0.00%> (+3.92%)	⬆️
app/services/execute_search.rb	94.44% <0.00%> (+5.55%)	⬆️

[govindgoel]

@Medlineme4 Can you mention the issue number above
If it is for #7580 then it is already completed so will be closing this pull request then

[Medlineme4]

#7598 Sent from Yahoo Mail on Android On Fri, Mar 6, 2020 at 12:17 PM, Govind Goel<notifications@github.com> wrote: @Medlineme4 Can you mention the issue number above — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[govindgoel]

@Medlineme4 This #7598 refers to the number of PR itself I want you to mention issue number for which you did pull request in the top comment section, not the title field.

[Medlineme4]

Can you explain more Sent from Yahoo Mail on Android On Fri, Mar 6, 2020 at 1:53 PM, Govind Goel<notifications@github.com> wrote: @Medlineme4 This refers to the PR itself — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Medlineme4]

I need help. I don't know how to find the issue. I saw it under first timers only. Sent from Yahoo Mail on Android On Fri, Mar 6, 2020 at 2:54 PM, medlinechinonye@yahoo.com<medlinechinonye@yahoo.com> wrote: Can you explain more Sent from Yahoo Mail on Android On Fri, Mar 6, 2020 at 1:53 PM, Govind Goel<notifications@github.com> wrote: @Medlineme4 This refers to the PR itself — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[Medlineme4]

change t to translation in _ events.html Sent from Yahoo Mail on Android On Fri, Mar 6, 2020 at 1:53 PM, Govind Goel<notifications@github.com> wrote: @Medlineme4 This refers to the PR itself — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[govindgoel]

You have made the pr for #7558 but you have to change the function t( ) to translation in specific lines, do the changes in the pr. Also, you have made the changes in a different file. Kindly fix this.

[Medlineme4]

I tried to but I couldn't open it. I saw another issue with same title but when I posted , it gave me a red mark Sent from Yahoo Mail on Android On Sat, Mar 7, 2020 at 9:18 AM, Govind Goel<notifications@github.com> wrote: @govindgoel requested changes on this pull request. You have made the pr for #7558 but you have to change the function t( ) to translation in specific lines, do the changes in the pr or else will be closing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cesswairimu]

Hi again @Medlineme4 thanks for opening this, no worries, travis misbehaves sometimes, restarting travis. Thanks

[stale]

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.