Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function t to translation in app/views/tag/show/_contributors.html.erb #7721 #7723

Conversation

nicoleiocana
Copy link
Contributor

Fixes #7721

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [✔️ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [✔️ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [N/A ] screenshots/GIFs are attached 📎 in case of UI updation
  • [N/A ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #7723 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7723   +/-   ##
=======================================
  Coverage   81.90%   81.90%           
=======================================
  Files          97       97           
  Lines        5615     5615           
=======================================
  Hits         4599     4599           
  Misses       1016     1016           

Copy link
Member

@govindgoel govindgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@SidharthBansal SidharthBansal merged commit b0fe8af into publiclab:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change function t to translation in app/views/tag/show/_contributors.html.erb
5 participants