Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed function t to translation in app/views/notes/index.html.erb #7759

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

AidenOliver
Copy link
Contributor

@AidenOliver AidenOliver commented Mar 31, 2020

Updated lines 12 and 14 in app/views/notes/index.html.erb.

Fixes #7759 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Updated lines 12 and 14 in apps/views/notes/index.html.erb.
@welcome
Copy link

welcome bot commented Mar 31, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #7759 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7759   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          97       97           
  Lines        5627     5627           
=======================================
  Hits         4611     4611           
  Misses       1016     1016           

@AidenOliver
Copy link
Contributor Author

Ready for review.

@nicoleiocana
Copy link
Contributor

@AidenOliver Below are a few changes that the reviewers will request from you:

  1. You might want to rename the commit message to something more appropriate (similar to Change function t to translation in app/views/notes/index.html.erb) so that when merged the commit history of the repo looks good. The procedure for the same in git is using git commit --amend .
  2. Could you please add the issue link up above on this line "Fixes #0000 (<=== Add issue number here)" to "Fixes 7731" , this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged.
  3. For future work please don't remove the checklist from the pull request description since it allows reviewers to have an understanding of the change easily.

I'm not an official reviewer, but I have seen these concerns pop up recently, so I figured that I should let you know.

@AidenOliver AidenOliver changed the title Updated index.html.erb lines 12 and 14 Changed function t to translation in app/views/notes/index.html.erb Mar 31, 2020
@SidharthBansal SidharthBansal merged commit ff5503e into publiclab:master Apr 2, 2020
@welcome
Copy link

welcome bot commented Apr 2, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

1 similar comment
@welcome
Copy link

welcome bot commented Apr 2, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants