Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: changes back to top button to uncover content #7823

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

mattp0
Copy link
Contributor

@mattp0 mattp0 commented Apr 16, 2020

Fixes #6352(<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 16, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #7823 into main will increase coverage by 0.02%.
The diff coverage is 82.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7823      +/-   ##
==========================================
+ Coverage   81.97%   81.99%   +0.02%     
==========================================
  Files          97      101       +4     
  Lines        5630     5899     +269     
==========================================
+ Hits         4615     4837     +222     
- Misses       1015     1062      +47     
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.17% <ø> (-0.14%) ⬇️
app/models/concerns/statistics.rb 96.72% <ø> (ø)
app/mailers/admin_mailer.rb 90.90% <12.50%> (-9.10%) ⬇️
app/jobs/digest_spam_job.rb 33.33% <33.33%> (ø)
app/models/user.rb 87.68% <45.00%> (-3.37%) ⬇️
app/controllers/spam2_controller.rb 71.84% <71.84%> (ø)
app/models/comment.rb 77.51% <83.33%> (+0.62%) ⬆️
app/controllers/notes_controller.rb 83.46% <85.71%> (+0.06%) ⬆️
app/controllers/batch_controller.rb 90.19% <90.19%> (ø)
app/controllers/tag_controller.rb 81.40% <92.50%> (+0.90%) ⬆️
... and 42 more

Copy link
Member

@ananyaarun ananyaarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi could you pls attach a screen shot of the changes made ?
Thanks for working on this !!

@jywarren
Copy link
Member

jywarren commented May 5, 2020

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@jywarren jywarren changed the base branch from master to main June 30, 2020 18:07
@jywarren jywarren closed this Sep 29, 2020
@jywarren jywarren reopened this Sep 29, 2020
@jywarren jywarren merged commit b7d0ba1 into publiclab:main Sep 29, 2020
@welcome
Copy link

welcome bot commented Sep 29, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Sorry this was so slow, but your changes are now merged, thank you so much!!! 🎉 🎉

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix back to top button for mobile view
3 participants