Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise qids query to select smaller subset #8264

Closed
wants to merge 1 commit into from

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #8242

WIP: Since there are multiple places where qid thing is used need to find and optimise at all places

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
    Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 7, 2020

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #8264 into main will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8264      +/-   ##
==========================================
- Coverage   81.44%   81.35%   -0.09%     
==========================================
  Files         101      101              
  Lines        5873     5873              
==========================================
- Hits         4783     4778       -5     
- Misses       1090     1095       +5     
Impacted Files Coverage Δ
app/controllers/tag_controller.rb 82.01% <100.00%> (+0.60%) ⬆️
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.24% <0.00%> (-3.83%) ⬇️

@Tlazypanda Tlazypanda closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qids optimization on /wiki/tag/method ?
1 participant