Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert signup validation changes #8466

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Revert signup validation changes #8466

merged 1 commit into from
Oct 6, 2020

Conversation

cesswairimu
Copy link
Collaborator

@cesswairimu cesswairimu commented Oct 6, 2020

Fixes #8461

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@cesswairimu cesswairimu requested a review from a team as a code owner October 6, 2020 19:37
@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@bb75633). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8466   +/-   ##
=======================================
  Coverage        ?   81.89%           
=======================================
  Files           ?      101           
  Lines           ?     5899           
  Branches        ?        0           
=======================================
  Hits            ?     4831           
  Misses          ?     1068           
  Partials        ?        0           

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Oct 6, 2020

Separating these two #8465 is discarding changes from these two files when I resolve the conflicts.

@jywarren jywarren merged commit c0b354e into main Oct 6, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants