Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Travis runtime #8951

Closed
wants to merge 2 commits into from
Closed

Reduce Travis runtime #8951

wants to merge 2 commits into from

Conversation

Manasa2850
Copy link
Member

Fixes #6225 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jan 6, 2021

@Manasa2850 Manasa2850 changed the title trigger build Reduce Travis runtime Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7a40239). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8951   +/-   ##
=======================================
  Coverage        ?   81.93%           
=======================================
  Files           ?      100           
  Lines           ?     5950           
  Branches        ?        0           
=======================================
  Hits            ?     4875           
  Misses          ?     1075           
  Partials        ?        0           

@codeclimate
Copy link

codeclimate bot commented Jan 7, 2021

Code Climate has analyzed commit b7e5ecf and detected 0 issues on this pull request.

View more on Code Climate.

@Manasa2850
Copy link
Member Author

@jywarren @cesswairimu is there a way to run unit, integration, functional and system tests in parallel? I tried build staging but I'm not sure why that too ran the tests in series

@cesswairimu
Copy link
Collaborator

Hi @Manasa2850, looks like we forgot to close Travis related issues...we moved from Travis and we are now using github actions for CI..so I am not sure there is a way we can test this or if we will ever go back to using Travis...as per your question I don't know of any. Thanks

@Manasa2850
Copy link
Member Author

Oh okay @cesswairimu. I've added caching which reduces the build time by 4 mins. Will this PR be of any use? If not, I'll close it for now.
Thank you!

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jan 7, 2021

we can merge it when its ready in case we wonna use Travis in the future...

@Manasa2850 Manasa2850 marked this pull request as ready for review January 7, 2021 07:19
@Manasa2850
Copy link
Member Author

The build time has reduced by 4 minutes.

Before:
before

After:
after_caching

@cesswairimu this PR can be merged now! If I figure out a way to run tests in parallel sometime later on I'll make another PR for that. Thanks!

@cesswairimu
Copy link
Collaborator

The test runner does not use travis.yml(I think) and it looks like it fluctuates e.g on this PR here it ran in 13mins #8928 ...I think we might not be able to test this and we might resolve to closing...so sorry for the confusion

@Manasa2850
Copy link
Member Author

Manasa2850 commented Jan 7, 2021

Oh okay @cesswairimu. Even I'm not sure why it doesn't use .travis.yml
No problem, I'll be closing this PR now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Travis runtime with caching
2 participants