-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added errorMessage partial to user sessions form #8973
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #8973 +/- ##
=======================================
Coverage ? 74.41%
=======================================
Files ? 100
Lines ? 6075
Branches ? 0
=======================================
Hits ? 4521
Misses ? 1554
Partials ? 0 |
Hi @gucci-ninja! I took a look at the tests that were failing... Hmm... That's weird, they don't seem to be related to what you're working on. Just FYI (and maybe you know this already), you can look at the test results here by clicking on Details: Sometimes the tests will fail not necessarily because of the PR. If they fail relatively quickly, like 5-10 minutes, you can run them again by clicking on Re-run jobs here: I just tried re-running them for you, let's see what happens! |
@noi5e yeah I noticed so I haven't put the PR up for review yet. Lots of |
Hmm, weird. I did notice that the continuous integration tests that were failing the second time were different, and there were new errors that weren't there the first time. I think it would help reviewing your code if you could paste screenshots of the Rails stacktrace |
@@ -1,6 +1,7 @@ | |||
class UserSessionsController < ApplicationController | |||
before_action :require_no_user, only: [:new] | |||
def new | |||
@user_session = UserSession.new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this wasn't specified in the original issue?
Sorry I can't be more helpful, this isn't really my expertise, but perhaps @cesswairimu @jywarren or @sagarpreet-chadha could help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I added that in after noticing the tests were failing. Thanks a lot for looking into this btw. I'll post the stack trace as well
Code Climate has analyzed commit 59f223e and detected 0 issues on this pull request. View more on Code Climate. |
@gucci-ninja it's not because of |
@coder645 Sounds good! I'll keep an eye out for when it reopens! Thanks for your help everyone 💯 |
Hi @gucci-ninja, there are these new ftos #8974 and #8975 if you are still looking for another fto. Thanks |
Fixes #8959 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!