Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed answered_questions code #9119

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

Manasa2850
Copy link
Member

@Manasa2850 Manasa2850 commented Feb 3, 2021

Fixes #8804 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Feb 3, 2021

@Manasa2850 Manasa2850 changed the title removed answered_questions and test Removed answered_questions code Feb 3, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 3, 2021

Code Climate has analyzed commit 5dfc144 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@b300979). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9119   +/-   ##
=======================================
  Coverage        ?   50.07%           
=======================================
  Files           ?      100           
  Lines           ?     6115           
  Branches        ?        0           
=======================================
  Hits            ?     3062           
  Misses          ?     3053           
  Partials        ?        0           

@jywarren
Copy link
Member

jywarren commented Feb 5, 2021

Thank you so much, this is great!! cc #4094 and #956

@jywarren jywarren merged commit 6ded8c4 into publiclab:main Feb 5, 2021
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@Manasa2850 Manasa2850 mentioned this pull request Feb 24, 2021
5 tasks
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all "answered_questions" code from app/controllers/tag_controller.rb
2 participants