Bump publiclab-editor from 3.0.1 to 3.0.2 #9323

dependabot-preview · 2021-03-16T23:15:25Z

Bumps publiclab-editor from 3.0.1 to 3.0.2.

Commits

See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

Update frequency
Automerge options (never/patch/minor, and dev/runtime dependencies)
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

Bumps [publiclab-editor](https://github.com/publiclab/PublicLab.Editor) from 3.0.1 to 3.0.2. - [Release notes](https://github.com/publiclab/PublicLab.Editor/releases) - [Commits](https://github.com/publiclab/PublicLab.Editor/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

gitpod-io · 2021-03-16T23:15:28Z

jywarren · 2021-03-16T23:18:46Z

Fixes publiclab/PublicLab.Editor#698

codecov · 2021-03-16T23:22:36Z

Codecov Report

❗ No coverage uploaded for pull request base (main@0908bfd). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1892301 differs from pull request most recent head 623400a. Consider uploading reports for the commit 623400a to get more accurate results

@@           Coverage Diff           @@
##             main    #9323   +/-   ##
=======================================
  Coverage        ?   82.26%           
=======================================
  Files           ?       98           
  Lines           ?     5870           
  Branches        ?        0           
=======================================
  Hits            ?     4829           
  Misses          ?     1041           
  Partials        ?        0

jywarren · 2021-03-17T12:55:22Z

Odd, the second doesn't seem editor related...

Not sure why the first one is failing either...

ERROR RichTextEditorTest#test_main_textarea_image_drag_and_drop_upload (83.86s)
Minitest::UnexpectedError:         ActiveRecord::RecordNotFound: Couldn't find Node with 'nid'=0
            app/controllers/images_controller.rb:36:in `create'

==[Screenshot]: tmp/screenshots/test_front_page_with_navbar_search_autocomplete.png
[Screenshot]: tmp/screenshots/test_searching_an_item_from_the_homepage.png
=[Screenshot]: tmp/screenshots/test_viewing_the_settings_page.png
=[Screenshot]: tmp/screenshots/failures_test_User_can_flag_a_node_from_dashboard.png
ERROR DashboardTest#test_User_can_flag_a_node_from_dashboard (220.49s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find visible css "div.alert" with text "Node flagged."
            test/system/dashboard_test.rb:35:in `block in <class:DashboardTest>'

jywarren · 2021-03-17T13:00:50Z

Oof now this error:


Progress: | FAIL TagSelectionTest#test_graph (0.40s)
        Expected: 18
          Actual: 23
        test/unit/tag_selection_test.rb:14:in `block in <class:TagSelectionTest>

cesswairimu · 2021-03-17T17:44:57Z

I've seen this error before I think...I will try to reopen

dependabot-preview · 2021-03-17T17:45:00Z

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

gitpod-io · 2021-03-17T17:45:04Z

jywarren · 2021-03-17T21:32:44Z

So weird this... but ok this is the only one i saw last time i ran it:

ERROR RichTextEditorTest#test_main_textarea_image_drag_and_drop_upload (195.82s)
Minitest::UnexpectedError:         ActiveRecord::RecordNotFound: Couldn't find Node with 'nid'=0
            app/controllers/images_controller.rb:36:in `create'

Really almost nothing else has changed about the editor though... since 3.0.0 - https://github.com/publiclab/PublicLab.Editor/commits

however it's odd, i don't actually see a commit for 3.0.1, i wonder if i published that from a branch mistakenly...

jywarren · 2021-03-18T22:10:22Z

That system test just won't pass. I think we should try running a diff on the library between v3.0.0 and v3.0.2 to see what changed, maybe it needs an additional patch.

jywarren · 2021-03-18T22:11:19Z

ERROR RichTextEditorTest#test_main_textarea_image_drag_and_drop_upload (657.58s)
Minitest::UnexpectedError:         ActiveRecord::RecordNotFound: Couldn't find Node with 'nid'=0
            app/controllers/images_controller.rb:36:in `create'

plots2/app/controllers/images_controller.rb

Lines 19 to 37 in 01242e5

    
           def create 
        
             if params[:i] 
        
               @image = Image.new(remote_url: params[:i], 
        
                                  uid: current_user.uid) 
        
               flash[:error] = 'The image could not be saved.' unless @image.save! 
        
             elsif params[:data] 
        
               filetype = params[:data].split(';').first.split('/').last 
        
               @image = Image.new(uid: current_user.uid, 
        
                                  photo: params[:data], 
        
                                  photo_file_name: 'dataurl.' + filetype) 
        
               @image.save! 
        
             else 
        
               @image = Image.new(uid: current_user.uid, 
        
                                  photo: params[:image][:photo], 
        
                                  title: params[:image][:title], 
        
                                  notes: params[:image][:notes]) 
        
             end 
        
             @image.nid = Node.find(params[:nid].to_i).nid unless params[:nid].nil? || params[:nid] == 'undefined' 
        
             if @image.save!

In fact based on line 36 maybe we can modify the Rails to detect 0 as being same as null?

codeclimate · 2021-03-18T22:15:36Z

app/controllers/images_controller.rb

@@ -33,7 +33,7 @@ def create
                         title: params[:image][:title],
                         notes: params[:image][:notes])
    end
-    @image.nid = Node.find(params[:nid].to_i).nid unless params[:nid].nil? || params[:nid] == 'undefined'
+    @image.nid = Node.find(params[:nid].to_i).nid unless params[:nid].nil? || params[:nid] == 'undefined' || params[:nid].to_i == 0


Use params[:nid].to_i.zero? instead of params[:nid].to_i == 0.

codeclimate · 2021-03-18T22:15:38Z

Code Climate has analyzed commit 623400a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Style	1

View more on Code Climate.

RuthNjeri · 2021-03-19T17:21:10Z

I did a rebuild of this issue and the tests are now passing, this should be okay? @jywarren or is the nid = 0 a concern?

jywarren · 2021-03-19T18:34:02Z

Wow i don't know why it passed this time, but it sounds great! We'll just watch out for this test failing again in future PRs. Thanks!!!

…

On Fri, Mar 19, 2021 at 1:21 PM Ruth ***@***.***> wrote: I did a rebuild of this issue and the tests are now passing, this should be okay? @jywarren <https://github.com/jywarren> or is the nid = 0 a concern? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9323 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J3ZXLQMATX3DO5A6ADTEOBZRANCNFSM4ZJPSTIQ> .

dependabot-preview bot added dependencies Pull requests that update a dependency file JavaScript labels Mar 16, 2021

jywarren mentioned this pull request Mar 16, 2021

Bad bug in /post editor (needs help tracing/reproducing) publiclab/PublicLab.Editor#698

Closed

cesswairimu closed this Mar 17, 2021

cesswairimu reopened this Mar 17, 2021

Update images_controller.rb

623400a

codeclimate bot reviewed Mar 18, 2021

View reviewed changes

RuthNjeri approved these changes Mar 19, 2021

View reviewed changes

dependabot-preview bot merged commit 07a243d into main Mar 19, 2021

dependabot-preview bot deleted the dependabot/npm_and_yarn/publiclab-editor-3.0.2 branch March 19, 2021 17:21

jywarren mentioned this pull request Apr 13, 2021

Image upload failing #9438

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump publiclab-editor from 3.0.1 to 3.0.2 #9323

Bump publiclab-editor from 3.0.1 to 3.0.2 #9323

dependabot-preview bot commented Mar 16, 2021

gitpod-io bot commented Mar 16, 2021 •

edited

Loading

jywarren commented Mar 16, 2021

codecov bot commented Mar 16, 2021 •

edited

Loading

jywarren commented Mar 17, 2021

jywarren commented Mar 17, 2021

cesswairimu commented Mar 17, 2021

dependabot-preview bot commented Mar 17, 2021

gitpod-io bot commented Mar 17, 2021

jywarren commented Mar 17, 2021

jywarren commented Mar 18, 2021

jywarren commented Mar 18, 2021 •

edited

Loading

codeclimate bot Mar 18, 2021

codeclimate bot commented Mar 18, 2021

RuthNjeri commented Mar 19, 2021

jywarren commented Mar 19, 2021 via email

Bump publiclab-editor from 3.0.1 to 3.0.2 #9323

Bump publiclab-editor from 3.0.1 to 3.0.2 #9323

Conversation

dependabot-preview bot commented Mar 16, 2021

gitpod-io bot commented Mar 16, 2021 • edited Loading

jywarren commented Mar 16, 2021

codecov bot commented Mar 16, 2021 • edited Loading

Codecov Report

jywarren commented Mar 17, 2021

jywarren commented Mar 17, 2021

cesswairimu commented Mar 17, 2021

dependabot-preview bot commented Mar 17, 2021

gitpod-io bot commented Mar 17, 2021

jywarren commented Mar 17, 2021

jywarren commented Mar 18, 2021

jywarren commented Mar 18, 2021 • edited Loading

codeclimate bot Mar 18, 2021

Choose a reason for hiding this comment

codeclimate bot commented Mar 18, 2021

RuthNjeri commented Mar 19, 2021

jywarren commented Mar 19, 2021 via email

gitpod-io bot commented Mar 16, 2021 •

edited

Loading

codecov bot commented Mar 16, 2021 •

edited

Loading

jywarren commented Mar 18, 2021 •

edited

Loading