Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unused Variable in spam2_controller_test #9360 #9364

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

achhetr
Copy link
Contributor

@achhetr achhetr commented Mar 23, 2021

Fixes #9360 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [X ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 23, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Mar 23, 2021

@codeclimate
Copy link

codeclimate bot commented Mar 23, 2021

Code Climate has analyzed commit 4c6987a and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c188b97). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head cfa5a4c differs from pull request most recent head 4c6987a. Consider uploading reports for the commit 4c6987a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9364   +/-   ##
=======================================
  Coverage        ?   81.36%           
=======================================
  Files           ?       98           
  Lines           ?     5930           
  Branches        ?        0           
=======================================
  Hits            ?     4825           
  Misses          ?     1105           
  Partials        ?        0           

Copy link
Member

@waridrox waridrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there was a slight mis-info regarding the issue to change for the node1 variable section as status: 4 instead of status: 0 😅 but awesome job on figuring out yourself! 🎉 😄

Copy link
Member

@pydevsg pydevsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @achhetr 🎉 .

@RuthNjeri
Copy link
Contributor

Thanks for a great job @achhetr 🎉 and for the reviews @waridrox and @pydevsg ❤️

@RuthNjeri
Copy link
Contributor

It seems like there was a slight mis-info regarding the issue to change for the node1 variable section as status: 4 instead of status: 0 😅 but awesome job on figuring out yourself! 🎉 😄

Yes, I put in the wrong info for that, thanks for pointing that out, I have fixed it 😄

@RuthNjeri RuthNjeri merged commit 444a0e0 into publiclab:main Apr 1, 2021
@welcome
Copy link

welcome bot commented Apr 1, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Unused Variable in spam2_controller_test
4 participants