Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update show.html.erb #9683

Merged
merged 2 commits into from
May 31, 2021
Merged

Update show.html.erb #9683

merged 2 commits into from
May 31, 2021

Conversation

KSVSC
Copy link
Contributor

@KSVSC KSVSC commented May 26, 2021

Fixes #9682

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented May 26, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented May 26, 2021

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉. Do you mind adding the issue number like this #1234 in your comment above?

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7fe537a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9683   +/-   ##
=======================================
  Coverage        ?   81.89%           
=======================================
  Files           ?       98           
  Lines           ?     5928           
  Branches        ?        0           
=======================================
  Hits            ?     4855           
  Misses          ?     1073           
  Partials        ?        0           

@KSVSC
Copy link
Contributor Author

KSVSC commented May 26, 2021

LGTM . Do you mind adding the issue number like this #1234 in your comment above?

@TildaDares Yes, I have edited my comment. I see my PR failed one of the 8 tests (i.e., unit-tests) and am not clear about the issue from logs. Can you please guide me.

@TildaDares
Copy link
Member

TildaDares commented May 26, 2021

@KSVSC You added the PR number instead of the issue number. The failing test issue is being resolved, it's not your fault.

@KSVSC
Copy link
Contributor Author

KSVSC commented May 26, 2021

@TildaDares Rectified. Thanks for pointing!

@cesswairimu
Copy link
Collaborator

The failing test should be now fixed #9681 . will try to close and reopen.

@codeclimate
Copy link

codeclimate bot commented May 31, 2021

Code Climate has analyzed commit 369516e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@RuthNjeri RuthNjeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks @KSVSC 🎉

@RuthNjeri RuthNjeri merged commit 9c43a77 into publiclab:main May 31, 2021
@welcome
Copy link

welcome bot commented May 31, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate co-author names with comma
4 participants