-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update show.html.erb #9683
Update show.html.erb #9683
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉. Do you mind adding the issue number like this #1234 in your comment above?
Codecov Report
@@ Coverage Diff @@
## main #9683 +/- ##
=======================================
Coverage ? 81.89%
=======================================
Files ? 98
Lines ? 5928
Branches ? 0
=======================================
Hits ? 4855
Misses ? 1073
Partials ? 0 |
@TildaDares Yes, I have edited my comment. I see my PR failed one of the 8 tests (i.e., unit-tests) and am not clear about the issue from logs. Can you please guide me. |
@KSVSC You added the PR number instead of the issue number. The failing test issue is being resolved, it's not your fault. |
@TildaDares Rectified. Thanks for pointing! |
The failing test should be now fixed #9681 . will try to close and reopen. |
Code Climate has analyzed commit 369516e and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @KSVSC 🎉
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #9682
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!