-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try migrating to GitHub Actions from Travis for CI #189
Conversation
Thanks for opening this pull request! |
For some reason, when I open a PR from my feature branch, the workflow is not triggered. However, if I open a PR on my own forked repository, the GH action works: |
Aha! Yes I believe this is a security limitation. I believe we can get you
credentials to open on publiclab's as well!
…On Mon, Aug 2, 2021, 6:39 PM Alicia Paz ***@***.***> wrote:
For some reason, when I open a PR from my feature branch, the workflow is
not triggered. However, if I open a PR on my own forked repository, the GH
action works:
aliciapaz#1 <aliciapaz#1>
@jywarren <https://github.com/jywarren> what do you think might be wrong?
On the other hand, this made me realize I can test the workflows in my
forked repository before I open the PR in the base repo :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#189 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J7BQVBDRGOQH6NTV5LT24NDRANCNFSM5BI54NWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Hi Alicia - just wondering if we could sync up in Gitter or another channel? Thanks! I checked permissions and i know there's something about it that's a bit hard to remember -- if I make you a contributor on this repo, you should be able to open it from a branch of publiclab/webjack, not aliciapaz/webjack, and i think that will help? But i'm not 100% sure. This looks all good, for starters: |
This document is strangely unhelpful: https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization |
So glad to see you're digging into this! |
Moving to #191 🎉 |
Based on similar work on: publiclab/spectral-workbench.js#207 and publiclab/image-sequencer#1783
Let's see how this goes!