Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try migrating to GitHub Actions from Travis for CI #189

Closed
wants to merge 4 commits into from

Conversation

aliciapaz
Copy link
Collaborator

Based on similar work on: publiclab/spectral-workbench.js#207 and publiclab/image-sequencer#1783

Let's see how this goes!

@welcome
Copy link

welcome bot commented Jul 30, 2021

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@aliciapaz
Copy link
Collaborator Author

For some reason, when I open a PR from my feature branch, the workflow is not triggered. However, if I open a PR on my own forked repository, the GH action works:
aliciapaz#1
@jywarren what do you think might be wrong?
On the other hand, this made me realize I can test the workflows in my forked repository before I open the PR in the base repo :)

@jywarren
Copy link
Member

jywarren commented Aug 3, 2021 via email

@jywarren
Copy link
Member

jywarren commented Aug 3, 2021

Hi Alicia - just wondering if we could sync up in Gitter or another channel? Thanks!

I checked permissions and i know there's something about it that's a bit hard to remember -- if I make you a contributor on this repo, you should be able to open it from a branch of publiclab/webjack, not aliciapaz/webjack, and i think that will help? But i'm not 100% sure.

This looks all good, for starters:

image

@jywarren
Copy link
Member

jywarren commented Aug 3, 2021

@jywarren
Copy link
Member

jywarren commented Aug 3, 2021

So glad to see you're digging into this!

@jywarren
Copy link
Member

jywarren commented Aug 4, 2021

Moving to #191 🎉

@jywarren jywarren closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants