Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowflake Inc domains to PRIVATE section #1634

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

sfc-gh-shaar
Copy link
Contributor

@sfc-gh-shaar sfc-gh-shaar commented Oct 27, 2022

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowlegements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Snowflake is a major cloud data warehousing and analytics solution. Streamlit is a Snowflake product, that turns data scripts into shareable web apps in minutes. All in pure Python. No front‑end experience required.

Snowflake offers the Streamlit Community Cloud where users can host Streamlit apps on individual domains, and is soon to release similar a similar offering for Snowflake.

I'm a Software Engineer on the Streamlit team at Snowflake .

Organization Website: https://www.snowflake.com/

Reason for PSL Inclusion

This PR adds three more domains to Snowflake Inc's contributions, submitted previously in #1591.

Number of users this request is being made to serve

  • streamlit.app over 20k
  • snowflake.app and privatelink.snowflake.app will serve the very many Snowflake users. The exact number I'm not at liberty to disclose, but it's a large amount. If this isn't satisfactory please let me know.
  • We provide customers with a unique subdomain from this set.
  • We want our customers' apps to be fully isolated from each other (cookies, etc.)
  • We want to prevent setting cookies on the apex domains.

DNS Verification via dig

dig +short txt _psl.snowflake.app
"https://github.com/publicsuffix/list/pull/1634"

dig +short txt _psl.streamlit.app
"https://github.com/publicsuffix/list/pull/1634"

Results of Syntax Checker (make test)

All tests pass

@dnsguru dnsguru added the DRAFT Submitter still working on, is draft, or appears inclomplete label Oct 31, 2022
@sfc-gh-shaar sfc-gh-shaar marked this pull request as ready for review November 3, 2022 20:34
@sfc-gh-shaar
Copy link
Contributor Author

Hi @dnsguru, just marked this ready for review. PTAL, thank you!

@dnsguru dnsguru added NOT IOS FB Submitter attests PR is not #1245 related and removed DRAFT Submitter still working on, is draft, or appears inclomplete labels Nov 7, 2022
@dnsguru dnsguru self-assigned this Feb 8, 2023
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Validates
  • Guidelines followed
  • Tests Pass
  • No Conflict with base

APPROVED

@dnsguru dnsguru merged commit 3c33add into publicsuffix:master Feb 8, 2023
@jeffrey-pinyan-cleandns jeffrey-pinyan-cleandns mentioned this pull request Jul 6, 2023
10 tasks
jeffrey-pinyan-cleandns added a commit to jeffrey-pinyan-cleandns/publicsuffix-list that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants