Removal of `blog.kg` from private section #1840

berkaycagir · 2023-09-02T16:10:55Z

I would like to remove my domain blog.kg from PSL (related: #1753).

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

Description of Organization
Robust Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (make test)
Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
This request was not submitted with the objective of working around other third-party limits
The Guidelines were carefully read and understood, and this request conforms
The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

I am acting on my own behalf as an individual.

Organization Website: N/A

Reason for PSL Inclusion

N/A, I would like to remove my domain from PSL.

Number of users this request is being made to serve: N/A

DNS Verification via dig

$ dig +short TXT _psl.blog.kg
"https://github.com/publicsuffix/list/pull/1840"

Results of Syntax Checker (`make test`)

$ make test
cd linter;                                \
	  ./pslint_selftest.sh;                     \
	  ./pslint.py ../public_suffix_list.dat;
-n test_NFKC:
OK
-n test_allowedchars:
OK
-n test_dots:
OK
-n test_duplicate:
OK
-n test_exception:
OK
-n test_punycode:
OK
-n test_section1:
OK
-n test_section2:
OK
-n test_section3:
OK
-n test_section4:
OK
-n test_spaces:
OK
-n test_wildcard:
OK
test -d libpsl || git clone --depth=1 https://github.com/rockdaboot/libpsl;   \
	  cd libpsl;                                                                    \
	  git pull;                                                                     \
	  echo "EXTRA_DIST =" >  gtk-doc.make;                                          \
	  echo "CLEANFILES =" >> gtk-doc.make;                                          \
	  autoreconf --install --force --symlink;
Already up to date.
autopoint: using AM_GNU_GETTEXT_REQUIRE_VERSION instead of AM_GNU_GETTEXT_VERSION
glibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
glibtoolize: linking file 'build-aux/ltmain.sh'
glibtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
glibtoolize: linking file 'm4/libtool.m4'
glibtoolize: linking file 'm4/ltoptions.m4'
glibtoolize: linking file 'm4/ltsugar.m4'
glibtoolize: linking file 'm4/ltversion.m4'
glibtoolize: linking file 'm4/lt~obsolete.m4'
configure.ac:1: warning: file `version.txt' included several times
configure.ac:4: warning: file `version.txt' included several times
aclocal.m4:765: AM_INIT_AUTOMAKE is expanded from...
configure.ac:4: the top level
configure.ac:383: warning: file `version.txt' included several times
configure.ac:10: installing 'build-aux/compile'
configure.ac:4: installing 'build-aux/missing'
fuzz/Makefile.am: installing 'build-aux/depcomp'
cd libpsl && ./configure -q -C --enable-runtime=libicu --enable-builtin=libicu --with-psl-file=/Users/berkay/GitHub/public-suffix-list/public_suffix_list.dat --with-psl-testfile=/Users/berkay/GitHub/public-suffix-list/tests/tests.txt && make -s clean && make -s check -j4
configure: WARNING: --enable-builtin=libicu is deprecated, use --enable-builtin (enabled by default)
config.status: creating po/POTFILES
config.status: creating po/Makefile
Making clean in po
Making clean in include
Making clean in src
rm -f ./so_locations
Making clean in tools
 rm -f psl
Making clean in fuzz
 rm -f libpsl_icu_fuzzer libpsl_icu_load_fuzzer libpsl_icu_load_dafsa_fuzzer
Making clean in tests
 rm -f test-is-public test-is-public-all test-is-cookie-domain-acceptable test-is-public-builtin test-registrable-domain
Making clean in msvc
Making check in po
Making check in include
Making check in src
  CC       libpsl_la-lookup_string_in_fixed_set.lo
  CC       libpsl_la-psl.lo
  CCLD     libpsl.la
Making check in tools
  CC       psl.o
  CCLD     psl
Making check in fuzz
  CC       libpsl_fuzzer.o
  CC       main.o
  CC       libpsl_load_fuzzer.o
  CC       libpsl_load_dafsa_fuzzer.o
  CCLD     libpsl_icu_fuzzer
  CCLD     libpsl_icu_load_fuzzer
  CCLD     libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-all.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public
  CCLD     test-is-public-all
libtool: warning: '-no-install' is ignored for x86_64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for x86_64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: '-no-install' is ignored for x86_64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for x86_64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
  CCLD     test-registrable-domain
libtool: warning: '-no-install' is ignored for x86_64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public-all
PASS: test-is-public
PASS: test-registrable-domain
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

dnsguru · 2023-10-02T17:17:24Z

Running the unit tests on this - it appears that you'll need to make this change against a new snapshot of the PSL - you can open a new PR with a fresh branch and reference this PR, or you can update the base used. Can't walk you through the second option

dnsguru · 2023-10-02T17:18:16Z

OK looks like that's sorted out

berkaycagir · 2023-10-02T17:19:04Z

Yep, I had just rebased (or merged, I don't know for sure as I used the GH interface) the branch today. Do I need to do anything else?

dnsguru · 2023-10-02T17:20:01Z

dig +short TXT _psl.blog.kg @8.8.8.8
"https://github.com/publicsuffix/list/pull/1840"

dnsguru · 2023-10-02T17:28:58Z

This is taking a lot of time as it is tangled up (not unlike a string of holiday lights) with a ton of other PR #953 #1014 #1656 #1753 #1741 in what I can only technically describe as a hot, fugly mess left by the ghosted github accounts that set up neko.am and voxel.sh.

berkaycagir · 2023-10-02T17:31:19Z

☹️ Do you plan/wish to delete all of the affected entries in a single merge?

dnsguru · 2023-10-02T18:37:40Z

Working this out with the volunteers - would love to just delete all these but want to make sure there is no 'friendly fire' scenarios that occur unintentionally from pulling the entirety of them.

Your individual domain name and not having you held up in the whole batch dialog is part of the discussion.

I also created #1866 about this

dnsguru · 2023-10-02T19:03:35Z

it took a lot of review to ensure low impact, which required reviewing all impacted domains for each of the inter-connected pull requests, one by one.

The current plan is to process #1741 and #1755 which will solve your issue, but we need the author of #1755 to update theirs, perhaps you can nudge them?

berkaycagir · 2023-10-02T19:16:01Z

Thanks a lot for letting me know.

I checked #1755 but that domain doesn't satisfy the registration duration requirement anyway, is there any point in trying to get the author to update it? In fact it never satisfied that requirement, and on their website it's not listed as a service as well, so I have a fair guess of that PR (and the domain as well) dying down.

berkaycagir · 2023-10-02T19:32:30Z

I dug deeper into #1755 a bit more and it gets weirder. While https://nic.us.kg exists, it's not managed by the author's non-profit but an alleged company called EdgeAlpha Ltd: https://nic.us.kg/terms-of-service/

Almost the same thing was mentioned before in the PR, but with an entirely different alleged company name. The author acknowledged this but didn't do any changes in their PR, which poses yet another issue on top of the registration duration requirement.

At this point it feels like a child's play to me, does it really make sense to hold all the other invalid entries just because of this? ☹️

dnsguru · 2023-10-02T20:29:31Z

fair point. will review more when additional volunteer cycles are available again

dnsguru

Sorted to Guidelines
DNS TXT = Pull Request URL
Tests Pass
No conflict with base

APPROVED

berkaycagir · 2024-02-02T09:28:23Z

Thank you!

Remove blog.kg from private section

9fdf3ab

berkaycagir changed the title ~~Removal of blog.kg from private section~~ Removal of blog.kg from private section Sep 2, 2023

berkaycagir added 2 commits September 21, 2023 20:12

Merge branch 'publicsuffix:master' into remove-blog-kg

d88b402

Merge branch 'publicsuffix:master' into remove-blog-kg

407c86e

dnsguru added the ❌FAIL - REBASE NEEDED Got out of synch with the repo and needs a re-base on it label Oct 2, 2023

dnsguru removed the ❌FAIL - REBASE NEEDED Got out of synch with the repo and needs a re-base on it label Oct 2, 2023

dnsguru self-assigned this Oct 2, 2023

dnsguru mentioned this pull request Oct 2, 2023

Case Study for removal automation of PRs submitted by accounts deleted by Github / "Ghosts" #1866

Closed

berkaycagir added 4 commits October 19, 2023 13:56

Merge branch 'publicsuffix:master' into remove-blog-kg

1765207

Merge branch 'publicsuffix:master' into remove-blog-kg

beb2113

Merge branch 'publicsuffix:master' into remove-blog-kg

a877ec2

Merge branch 'publicsuffix:master' into remove-blog-kg

7784dd2

Merge branch 'publicsuffix:master' into remove-blog-kg

00cfe9b

dnsguru approved these changes Feb 2, 2024

View reviewed changes

dnsguru merged commit 90a62a1 into publicsuffix:master Feb 2, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removal of `blog.kg` from private section #1840

Removal of `blog.kg` from private section #1840

berkaycagir commented Sep 2, 2023 •

edited

Loading

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023 •

edited

Loading

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

dnsguru commented Oct 2, 2023

dnsguru left a comment

berkaycagir commented Feb 2, 2024

Removal of blog.kg from private section #1840

Removal of blog.kg from private section #1840

Conversation

berkaycagir commented Sep 2, 2023 • edited Loading

Public Suffix List (PSL) Pull Request (PR) Template

Checklist of required steps

Description of Organization

Reason for PSL Inclusion

DNS Verification via dig

Results of Syntax Checker (make test)

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023 • edited Loading

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

dnsguru commented Oct 2, 2023

dnsguru commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

berkaycagir commented Oct 2, 2023

dnsguru commented Oct 2, 2023

dnsguru left a comment

Choose a reason for hiding this comment

berkaycagir commented Feb 2, 2024

Removal of `blog.kg` from private section #1840

Removal of `blog.kg` from private section #1840

berkaycagir commented Sep 2, 2023 •

edited

Loading

Results of Syntax Checker (`make test`)

berkaycagir commented Oct 2, 2023 •

edited

Loading