Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lelux.site #849

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Add lelux.site #849

merged 3 commits into from
Jul 17, 2019

Conversation

theel0ja
Copy link
Contributor

@theel0ja theel0ja commented Jul 16, 2019

  • Description of Organization
  • Reason for PSL Inclusion
  • DNS verification via dig
  • Run Syntax Checker (make test)

Description of Organization

Organization Website: https://lelux.fi/

Organization providing services powered by free software. (related: https://libreho.st/)

I'm the administator of Lelux.fi.

Reason for PSL Inclusion

Going to be used for a public GitLab Pages instance.

DNS Verification via dig

dig +short TXT _psl.lelux.site
"https://github.com/publicsuffix/list/pull/849"

make test

I ran the test and it passed succesfully.

@sleevi
Copy link
Contributor

sleevi commented Jul 16, 2019

You didn't share edit privileges, so I can't correct the issue by pointing the organization domain to lelux.fi , rather than the (not serving content) lelux.site

@sleevi sleevi added the waiting-followup Blocked for need of follow-up label Jul 16, 2019
@theel0ja
Copy link
Contributor Author

Fixed, if this is what you want.

@sleevi
Copy link
Contributor

sleevi commented Jul 17, 2019

It's normally easier if you allow maintainers to edit your pull requests. In looking at this again, another issue is that it's not sorted correctly - Lelux.fi does not come before GitHub.com when sorting by organization name. I would normally fix this so that it matches the Guidelines, but you'll need to do this.

@theel0ja
Copy link
Contributor Author

@sleevi allowed edits from maintainers

@sleevi sleevi added h=sleevi (historical) Marked as approved and ready to merge by @sleevi and removed waiting-followup Blocked for need of follow-up labels Jul 17, 2019
@sleevi sleevi self-requested a review July 17, 2019 18:50
@sleevi
Copy link
Contributor

sleevi commented Jul 17, 2019

Thanks. I corrected the sorting now.

@sleevi sleevi merged commit e8812ff into publicsuffix:master Jul 17, 2019
@jeffrey-pinyan-cleandns jeffrey-pinyan-cleandns mentioned this pull request Jul 6, 2023
10 tasks
jeffrey-pinyan-cleandns added a commit to jeffrey-pinyan-cleandns/publicsuffix-list that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
h=sleevi (historical) Marked as approved and ready to merge by @sleevi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants