Temp/testing unity export android #31

abanoubdev · 2021-02-15T14:16:47Z

Fix Hybid Demo and validate showing banner

Add button for loading banner Add script for new banner

Add onclick method and button

Modify scence to have 2 buttons : one to show on top another one to show on bottom

Save MainDemoScence inside assets

update UnityPlayerActivity.java

Add HybidViewViewBridge inside mainDemoScene link button clicks with methods inside mono behaviour class

Remove unused update method

dummy commit

Add HybidBridge and button clicks in the same main scence

fix crash of demo app export new android project with 4 buttons showing add HybidBridge to validate clicking loadHybidAdTop and loadHybidAdBottom

Export new android project inside Android folder

Update gradle and revert UnitPlayerActivity

add ad initialization after app is initialized

Add Location permission in start of application

Add try catch for whole loading method of banner Export new androidlib folder with new configurations Fix looping issue

clean up build files

Update .gitignore

…nity_export_android

Dummy commit

orkhanalizada2020 · 2021-02-15T14:35:03Z

...rary/hybidwrapper.androidlib/src/main/java/net/pubnative/unityplugin/HyBidAdViewWrapper.java

+    private void loadBanner(String appToken, final String placementId, int position) {
+        final HyBidAdView.Position bannerPosition;
+
+        if (position == getTopPosition()) {


can be replaced with ternary operator to shorten

Cool ,will do this

orkhanalizada2020 · 2021-02-15T14:35:46Z

...rary/hybidwrapper.androidlib/src/main/java/net/pubnative/unityplugin/HyBidAdViewWrapper.java

+                HyBid.initialize(appToken, UnityPlayer.currentActivity.getApplication(), new HyBid.InitialisationListener() {
+                    @Override
+                    public void onInitialisationFinished(boolean b) {
+                        hyBidAdView = new HyBidAdView(UnityPlayer.currentActivity);


code duplication. You could move it into a separate func and to call it then

There is only 1 method loadBanner and it is called in all cases
I already did it in last commit

I was talking about those lines:

hyBidAdView = new HyBidAdView(UnityPlayer.currentActivity); hyBidAdView.setAdSize(AdSize.SIZE_320x50); hyBidAdView.load(placementId, bannerPosition, HyBidAdViewWrapper.this);

orkhanalizada2020 · 2021-02-15T14:39:49Z

...roid/hybidwrapper.androidlib/src/main/java/net/pubnative/unityplugin/HyBidAdViewWrapper.java

+    private void loadBanner(String appToken, final String placementId, int position) {
+        final HyBidAdView.Position bannerPosition;
+
+        if (position == getTopPosition()) {


ternary here might be applied

Cool ,will do this

orkhanalizada2020 · 2021-02-15T14:40:12Z

...roid/hybidwrapper.androidlib/src/main/java/net/pubnative/unityplugin/HyBidAdViewWrapper.java

+                HyBid.initialize(appToken, UnityPlayer.currentActivity.getApplication(), new HyBid.InitialisationListener() {
+                    @Override
+                    public void onInitialisationFinished(boolean b) {
+                        hyBidAdView = new HyBidAdView(UnityPlayer.currentActivity);


duplication here also with line #96

Same as above :)

orkhanalizada2020 · 2021-02-15T14:41:16Z

Unity/Assets/Scripts/HyBidAdView.cs

@@ -8,52 +8,30 @@ public abstract class HyBidAdView : MonoBehaviour
 {
    public string appToken;
 	public string placement;
-	protected string adID = "";


why did you remove listeners?

Because once ad is loaded ,its callbacks is inside native code and send response to virtual methods inside unity

I would double check that moment. Those changes might break one of the platform side functionality

orkhanalizada2020 · 2021-02-15T14:41:59Z

Unity/Assets/Scripts/HyBidAndroidBanner.cs

@@ -19,6 +19,8 @@ public HyBidAndroidBanner ()

 	public override void Load (int position)
 	{
+		appToken = "dde3c298b47648459f8ada4a982fa92d";


why did you hardcoded appToken and placementID here?

orkhanalizada2020 · 2021-02-15T14:43:23Z

Unity/Assets/Scripts/HybidNative.cs

+
+    void Start()
+    {
+        banner = HyBidAdViewFactory.createHyBidAdView(this);


will all your changes break the iOS-ready functionality? Have you checked that?

I'm creating a merge branch to fix these conflicts. I'll mix the commits and then merge into the PR branch to solve the issues

the thing is there some point which might not cause conflicts. For example, listeners removal will not cause any conflict, I believe, but can break the functionality

Yes for sure. I meant conflicts in the functionality in this case. But no worries I'll mix it without breaking the functionality.

Revert all changes of sample to working demo with all banner showing top and bottom

Abanoub and others added 26 commits February 4, 2021 12:05

demo fix

e97fe56

Add button for loading banner Add script for new banner

Add click listener for load button inside unity

c4f7d7e

Add onclick method and button

Add button to show Bottom banner

b154e62

Modify scence to have 2 buttons : one to show on top another one to show on bottom

Save MainDemoScence

1832e03

Save MainDemoScence inside assets

update classes.jar

1a67cac

update UnityPlayerActivity.java

Add HybidAdViewBrdige

dd101bc

Add HybidViewViewBridge inside mainDemoScene link button clicks with methods inside mono behaviour class

Remove unused update method

e61ced1

Remove unused update method

dummy commit

8ff228e

dummy commit

add use.AndroidX=true inside gradle.properties

25ea171

Add HybidBridge and button clicks in the same main scence

5fde636

Add HybidBridge and button clicks in the same main scence

Add exported unity project

468c534

Clean up old demo

c76a06a

Update exported unity demo Android

dbafd1d

fix Demo app crash

b59268b

fix crash of demo app export new android project with 4 buttons showing add HybidBridge to validate clicking loadHybidAdTop and loadHybidAdBottom

Demo App Load Top and Bottom

1dec3a9

Export new android project inside Android folder

Update gradle and revert UnitPlayerActivity

3dfbb5d

Update gradle and revert UnitPlayerActivity

update rewarded and interstitial wrappers

f60d10a

add ad initialization after app is initialized

Add Location permission in start of application

fd6208c

Add Location permission in start of application

Remove HyBidAdView initialisation from wrapper constructor

e4f4208

Clean up ignored files

9cdd2f4

Add changes on HyBidNative script

7d84478

Fix Show Banner Top and Bottom issue

a2f1978

Add try catch for whole loading method of banner Export new androidlib folder with new configurations Fix looping issue

clean up build files

92cd956

clean up build files

Update .gitignore

989b018

Update .gitignore

Merge remote-tracking branch 'origin/development' into temp/testing_u…

1f7af1a

…nity_export_android

Dummy commit

fbb568e

Dummy commit

abanoubdev requested review from eros902002 and orkhanalizada2020 February 15, 2021 14:25

orkhanalizada2020 reviewed Feb 15, 2021

View reviewed changes

Revert changes to a working sample

d512126

Revert all changes of sample to working demo with all banner showing top and bottom

Temp/testing unity export android #31

Are you sure you want to change the base?

Temp/testing unity export android #31

Uh oh!

Conversation

abanoubdev commented Feb 15, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orkhanalizada2020 Feb 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

orkhanalizada2020 Feb 15, 2021 •

edited

Loading