Address issue that returned poll immediately
#231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue because of which `poll` always returned immediately without waiting for the actual event (TLS handshake flow uses proper watcher now).
parfeon
added
status: done
Xavrax
approved these changes
Sep 22, 2025
|
|
||
| /* Handles socket condition on given platform */ | ||
| enum pubnub_res pbpal_handle_socket_condition(int result, pubnub_t* pb, char const* file, int line); | ||
| enum pubnub_res pbpal_handle_socket_condition(int result, pubnub_t* pb, char const* file, int line, bool *needRead, bool* needWrite); |
There was a problem hiding this comment.
I would recommend using tribool instead of bool ptr.
There was a problem hiding this comment.
Hmmm, but we use bools in other functions. I still not really sure what happened that we needed that pubnub_tribool enum.
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(poller): address issue that returned
pollimmediatelyFix the issue because of which
pollalways returned immediately without waiting for the actual event (TLS handshake flow uses proper watcher now).