test: add missing unit and integration test #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 1, 2025 22:23
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
parfeon
added
status: done
parfeon
approved these changes
Sep 12, 2025
| /** | ||
| * The subscriber uuid to get the current state. | ||
| */ | ||
| uuid: string; |
There was a problem hiding this comment.
uuid is present in Presence.GetPresenceStateParameters and set by SDK itself if user omit to the currently configured userId.
| if (!serviceResponse.payload) return { channels: [] }; | ||
|
|
||
| return { channels: serviceResponse.payload.channels }; | ||
| return { channels: serviceResponse.payload.channels || [] }; |
There was a problem hiding this comment.
Was it found by crafted response? Server usually returns channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests added for input parameter validation and response parsing including edge cases.
additional integration tests for edge cases.