-
Notifications
You must be signed in to change notification settings - Fork 400
fix: presence event engine internal state sync #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
mohitpubnub
commented
Sep 26, 2025
parfeon
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* restore legacy crypto module support for React Native target * type(react-native): configuration type may contain cipherKey value. removed shaHMAC as not required in client app --------- Co-authored-by: Mohit Tejani <mohit.tejani@Mohits-MBP.lan> Co-authored-by: Mohit Tejani <mohit.tejani@Mohits-MacBook-Pro.local>
@pubnub-release-bot release |
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: presence event engine state synchronisation issue.
Resolves issue where presence heartbeat channels/groups sets were out of sync.
feat(react-native): restore legacy cryptography support
Reintroduced legacy encryption and decryption functions for the React Native target to ensure backward compatibility. This change merges PR #476.
Closes #474
refactor(presence): temporarily remove
offset
parameterTemporarily remove the
offset
parameter until implementation synchronization across SDKs is completed.