Skip to content

Upgrade tokio to v1 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 28, 2021
Merged

Upgrade tokio to v1 #61

merged 9 commits into from
Jun 28, 2021

Conversation

petrosagg
Copy link
Contributor

No description provided.

@petrosagg
upgrade to tokio v1
d533676 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
fix warning about renamed lint
e2e807d 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
Copy link
Contributor Author

It looks like the current master is broken as far as CI is concerned so I fixed the warnings in this branch to get the CI to pass

@petrosagg
Copy link
Contributor Author

The only thing that's failing now is beyond my control. It looks like the CI is missing some key? Or it's because the PR is from an external fork. @MOZGIII can you take a look?

@petrosagg petrosagg mentioned this pull request Mar 23, 2021
Merged
@650elx 650elx self-requested a review April 6, 2021 14:16
@650elx
Copy link

650elx commented Apr 6, 2021

@petrosagg Thanks for your contribution.
We are working on updating our RustSDK; I'll close this PR when we release updated version.

@petrosagg
Copy link
Contributor Author

hi @650elx. Is this still happening? Given the last commit to any of the branches is more than a year old would it make sense to merge this tokio v1 PR and then merging the updated SDK on top of it?

@petrosagg
Copy link
Contributor Author

We are currently forced to maintain a fork for this reason

@650elx
Copy link

650elx commented May 13, 2021

@petrosagg We're working on the completly new RustSDK (release date is neither known nor expected to come soon).
I'll try to incorporate your improvements into this repo next week.

@petrosagg petrosagg force-pushed the tokio-v1 branch 2 times, most recently from 84c6ad2 to 5fadd9f Compare June 10, 2021 09:48
petrosagg added 5 commits June 10, 2021 12:11
@petrosagg
fix cargo fmt and cargo clippy warnings
b3c96a0 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
update base64 crate to 0.13
d7f265c 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
update hmac and sha2 crates
7f253c8 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
update derive builder to 0.10
6981bfe 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
uritemplate is unmaintained, switch to uritemplate-next
1ced3e6 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg added 2 commits June 10, 2021 12:24
@petrosagg
update minimum rust version in CI to 1.46
3b3e5f0 
rust >= 1.41 is required to build subtle, see:
dalek-cryptography/subtle#77

rust >= 1.42 is required for the stabilization of the matches! macro

rust >= 1.43 is required for inclusion of usize::MAX required by socket2
which is required by hyper

rust >= 1.46 is required to allow match and if statements inside const
expressions, which is required by socket2 which is required by hyper

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
ignore failing test due to missing CI credentials
b929203 
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg
Copy link
Contributor Author

hey @650elx any luck with merging and releasing this PR? We've been using a fork of this in production for a while now with no issues and tests pass in CI

@petrosagg
Copy link
Contributor Author

Just a friendly ping, it would be great to get this PR in

650elx
650elx approved these changes Jun 28, 2021
View reviewed changes
Copy link

@650elx 650elx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrosagg Thanks for this valuable contribution.
I'll publish newer version of this package asap.

@650elx 650elx merged commit 859c4b0 into pubnub:master Jun 28, 2021
@petrosagg petrosagg deleted the tokio-v1 branch June 28, 2021 11:16
@petrosagg
Copy link
Contributor Author

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@650elx 650elx 650elx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrosagg @650elx