PubNub Swift Chat SDK 0.9.3 release #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
jguz-pubnub
force-pushed
the
fix/channel-send-text
branch
from
e71d567 to
f8bf0d4
Compare
marcin-cebo
approved these changes
Dec 18, 2024
| meta: ["a": 123, "b": "someString"], | ||
| shouldStore: true, | ||
| mentionedUsers: mentionedUsers, | ||
| referencedChannels: referencedChannels, | ||
| usersToMention: nil, |
There was a problem hiding this comment.
I understand that we don't test deprecated method any more. Wouldn't be beneficial to have also test for deprecated method if we still offer it to clients?
There was a problem hiding this comment.
Yes, I also added a test for the legacy method
|
@pubnub-release-bot release as 0.9.3-dev |
jguz-pubnub
force-pushed
the
fix/channel-send-text
branch
from
6bf420d to
d38e9b1
Compare
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(project): run
swiftformatto uplift the codebasefix(custom-payloads): add missing initialization for
reactionsActionNamepropertyfix(channel): add missing
completion:parameter when sending a text