Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Official Airflow Image apache/airflow:1.10.11 #576

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

swapniel99
Copy link

No description provided.

@swapniel99 swapniel99 changed the title Using Official Airflow Image Using Official Airflow Image apache/airflow:1.10.11 Jul 24, 2020
@neil90
Copy link

neil90 commented Aug 25, 2020

I would recommend people use this going forward.

@neil90
Copy link

neil90 commented Aug 25, 2020

The custom airflow.cfg doesnt seem to work, the only way i could get airflow configs changes to propagate was via doing it the Environment Variable.

@MeTaNoV
Copy link

MeTaNoV commented Aug 28, 2020

I would recommend people use this going forward.

I agree, @swapniel99, do you feel like maintaining a new fork repo based on your work?

@swapniel99
Copy link
Author

swapniel99 commented Aug 28, 2020

@MeTaNoV Sure. I have also made some enhancements in a private repo to make it as compatible to puckel's format as possible. I can publish them.

@MeTaNoV
Copy link

MeTaNoV commented Aug 28, 2020

@swapniel99 that would be gr8, yes! Thanks for your contribution!

@neil90
Copy link

neil90 commented Aug 28, 2020

@swapniel99 / @MeTaNoV I am happy to help contribute to your repo going forward. Can you let us know here when it is up to date and published? I currently have yours forked and am adding my own improvements well.

@swapniel99
Copy link
Author

@neil90 @MeTaNoV I have pushed my changes. Readme is not completely updated.
Also added image on dockerhub. somehow cant get the badge working :P

@swapniel99 swapniel99 mentioned this pull request Aug 28, 2020
@swapniel99 swapniel99 closed this Aug 28, 2020
@swapniel99 swapniel99 reopened this Aug 29, 2020
@swapniel99
Copy link
Author

The custom airflow.cfg doesnt seem to work, the only way i could get airflow configs changes to propagate was via doing it the Environment Variable.

I had not changed ownership of airflow home. probably that's why cfg didnt work.

@Jeoffreybauvin
Copy link

@swapniel99 I checked your repo. You're not using AIRFLOW_DEPS and PYTHON_DEPS anymore. Any reason ?

@swapniel99
Copy link
Author

@swapniel99 I checked your repo. You're not using AIRFLOW_DEPS and PYTHON_DEPS anymore. Any reason ?

Must have missed it since I was not using it in my vanilla image of private repo. Please feel free to contribute.

@fatjoni
Copy link

fatjoni commented Sep 29, 2020

everything worked great with the upgrade except the root user doesnt work as it did and is crucial to my solution. If you launch the containers with root user and - C_FORCE_ROOT=true as env (like it used to) containers fail, airflow is not found. Any ideas?

@jolo-dev
Copy link

jolo-dev commented Oct 2, 2020

Will that be merged anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants