Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated files #1

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Conversation

puellanivis
Copy link
Owner

When we are doing goimports and go fmt we are currently considering files that are ignored by golint because they beging with // Generated by … DO NOT EDIT.

The goprecommit tool should also ignore these files for goimports and go fmt. mockery for example outputs separate import lines for each imported package rather than a grouped import statement.

@puellanivis
Copy link
Owner Author

golang/go#13560 (comment) is the random governing convention. I need to update the regex.

@puellanivis puellanivis changed the title Ignore DO NOT EDIT generated files Ignore generated files Jan 21, 2020
@puellanivis puellanivis merged commit a045295 into master Jan 21, 2020
@puellanivis puellanivis deleted the patch/ignore-generated-code-files branch January 21, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant