Skip to content

Improve magic methods support #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 6, 2020
Merged

Improve magic methods support #34

merged 5 commits into from
Apr 6, 2020

Conversation

kylekatarnls
Copy link
Member

@kylekatarnls kylekatarnls commented Apr 5, 2020

Fix (partially) #33 Support in dot operator object that implements __get and __call but not __isset

Fix BKWLD/laravel-pug#82
And handle RegExp flags compatible with PHP

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #34 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #34   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       508       517    +9     
===========================================
  Files             34        34           
  Lines           1185      1206   +21     
===========================================
+ Hits            1185      1206   +21     
Impacted Files Coverage Δ Complexity Δ
src/JsPhpize/Compiler/Compiler.php 100.00% <100.00%> (ø) 79.00 <20.00> (+9.00)
src/JsPhpize/Nodes/Constant.php 100.00% <100.00%> (ø) 6.00 <2.00> (ø)
src/JsPhpize/Parser/TokenExtractor.php 100.00% <100.00%> (ø) 55.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a3f8e...6d3137e. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2020

Code Climate has analyzed commit 6d3137e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Clarity 1
Bug Risk 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@kylekatarnls kylekatarnls merged commit fb51f7b into master Apr 6, 2020
@kylekatarnls kylekatarnls deleted the magic-methods branch April 6, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking null value in pug from db call
1 participant