Add unit tests to describe bugs from #1261 and #997. #1264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are a couple of files missing (from the travis-ci results) |
|
... here it is. |
| block body | ||
| p body | ||
| block body | ||
| p in body in append head |
There was a problem hiding this comment.
Typo. p in body in replace body or something like that would be more appropriate here. ;)
Taking my thoughts on #1271 into account this once again highlights the ambiguity of the block my-block statement.
…e block is not referenced in the including .jade
…s ignored. The append action is not visible in the result, but the block append is not totally ignored as it yields the current value of the block.
…t's currently ignored. It works when the block is not already redefined in the extending block, see layout.block.replace-block-in-other-block-without-prior-block.jade (except for the unexpected yielding).
Closed
|
Stopped working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include.jade: the order of block appends is not the expected one (file order)
other .jade: block append should not return its value to its parent like block does: it should only modify the block it's referring to.