Skip to content

Commit

Permalink
Get a little farther in the test before failing (#1044)
Browse files Browse the repository at this point in the history
The date range is not currently actually being filled in. You can verify this by turning off "headless" mode and running the test with a byebug after line 64. There are two main errors in the console:
    `TypeError: m.includes is not a function`, raised from the updateRangeInput function in lux-styleguidist
    `TypeError: Cannot read properties of undefined`, raised from the toLocaleDateString function in lux-styleguidist
    See pulibrary/lux-design-system#107
  • Loading branch information
maxkadel authored and christinach committed Mar 8, 2024
1 parent 6e5d025 commit 8a3f4be
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions spec/features/report_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,17 @@
expect(page).to have_content "Vacation (15.5 hours) October 13, 2019 October 14, 2019 Approved Sally Smith ITIMS October 20, 2019"
expect(page).to have_content "Vacation (10.3 hours) October 12, 2019 October 13, 2019 Pending Pat Doe ITIMS"

select_drop_down(menu: "#status-menu", item: "Approved")
click_on "Status"
click_on "Approved"
assert_selector ".my-request tr", count: 5 # header row included in count

select_drop_down(menu: "#request-type-menu", item: "Travel")
click_on "Request type"
click_on "Travel"
assert_selector ".my-request tr", count: 3 # header row included in count

click_link("Status: Approved")
assert_selector ".my-request tr", count: 4

# The date range is not currently actually being filled in
# You can verify this by turning off "headless" mode and running the test with a byebug after the next line
fill_in "dateRange", with: "10/10/2019 - 10/25/2019"
click_on "Filter by Date"
assert_selector ".my-request tr", count: 2
Expand Down

0 comments on commit 8a3f4be

Please sign in to comment.