-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lux-styleguidist #984
Merged
Merged
Use lux-styleguidist #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9a7cdd
to
ccb5961
Compare
6b4f85b
to
8af7100
Compare
281b553
to
1679156
Compare
d092c3a
to
8b92e34
Compare
This was referenced Feb 26, 2024
@@ -1,9 +1,9 @@ | |||
<% if supervisor_filter_urls.count > 0 %> | |||
<input-select name="supervisor_filter" value="<%= current_supervisor_filter_label %>" onchange="location.href = this.children[0].value; //jump to link location on select" | |||
<lux-input-select name="supervisor_filter" value="<%= current_supervisor_filter_label %>" onchange="location.href = this.children[0].value; //jump to link location on select" |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
Error loading related location
Loading ccfdafe
to
008c3cf
Compare
* Removed hard-coded styles * Fixed missed merge conflict --------- Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>
…ttons (#1113) Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>
* Sending the escape key to close the autocomplete that was blocking buttons * Changed escape to tab --------- Co-authored-by: Ryan Laddusaw <rladdusaw@princeton.edu>
Fixes luxInputText border #1121 Fixes bug in autocompleteInput
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
4654896
to
443c95f
Compare
Mark Absence workflow tests as pending Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com> Co-authored-by: Kevin Reiss <kevinreiss@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@kevinreiss can you also check the branch on staging and confirm that we can merge? |
kevinreiss
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Apr 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update vue and vue dependencies to vue3
When starting rails server and running the application, the error that we see and try to fix is: