Display images and fix CI #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bess Sadler <bess@users.noreply.github.com> Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
hackartisan
requested changes
Aug 23, 2023
spec/system/subguide_cards_spec.rb
Outdated
| end | ||
|
|
||
| describe 'SubGuide page with image display' do | ||
| it 'shows all images for the SubGuide path' do |
There was a problem hiding this comment.
I'm not sure this is true. The test doesn't check for image tags, for example. It appears to check for some kind of title or heading.
I understand that we don't want to run the card image loading service in tests, because it hits aws. Instead, to test the show page functionality, we could create a card image object with a false value and test that the image tag is produced on the page.
| @@ -1,3 +1,7 @@ | |||
| <h1>SubGuideCards#show</h1> | |||
| <p>Find me in app/views/sub_guide_cards/show.html.erb</p> | |||
| <%= @sub_guide_card.heading %> | |||
| <%= @sub_guide_card.path %> | |||
| <% @card_images.each do |image| %> | |||
| <%= image_tag(image.iiif_url) %> | |||
| @@ -1,3 +1,7 @@ | |||
| <h1>SubGuideCards#show</h1> | |||
| <p>Find me in app/views/sub_guide_cards/show.html.erb</p> | |||
| <%= @sub_guide_card.heading %> | |||
| <%= @sub_guide_card.path %> | |||
There was a problem hiding this comment.
Do we want to print the sub guide card path on the show page? Maybe it was printed for debugging and we can remove it?
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
hackartisan
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Bess Sadler bess@users.noreply.github.com
Co-authored-by: Christina Chortaria christinach@users.noreply.github.com
Co-authored-by: Jane Sandberg sandbergja@users.noreply.github.com
Ref #19