Allow page navigation after search #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com>
hackartisan
requested changes
Sep 15, 2023
spec/models/guide_card_spec.rb
Outdated
| @@ -53,5 +53,9 @@ | |||
| guide_card19 = GuideCard.create(id: 19) | |||
| expect(guide_card19.index_page).to eq 2 | |||
| end | |||
| it 'id 27021 is on page 2702' do | |||
| guide_card27021 = GuideCard.create(id: 27021) | |||
| expect(guide_card27021.index_page).to eq 2702 | |||
There was a problem hiding this comment.
2703 seems right. we can update this test or remove it.
Note that these cards must be ordered by id, not heading. This is counterintuitive, because it results in a thing that might not look like alphabetical order. However, it is the order of the card catalog, which is wanted by the stakeholder. Co-authored-by: Bess Sadler <bess@users.noreply.github.com>
hackartisan
reviewed
Sep 19, 2023
| @@ -3,12 +3,17 @@ | |||
| # controller for GuideCards | |||
| class GuideCardsController < ApplicationController | |||
| def index | |||
| @guide_cards = GuideCard.page(params[:page]) | |||
| @guide_cards = GuideCard.order(:id).page(params[:page]) | |||
There was a problem hiding this comment.
There's a great commit message about why we're ordering by id. It might be nice to add a similar comment into the code.
There was a problem hiding this comment.
I have added this logic to our controller as a comment. Thank you!
Co-authored-by: Anna Headley <hackartisan@users.noreply.github.com> Co-authored-by: Bess Sadler <bess@users.noreply.github.com>
hackartisan
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #22