add test for invalid_tag

[pmgreen]

Closes #69

[Beck-Davis]

Separate methods should have separate test blocks under the RSpec.describe. We should avoid nesting tests in unrelated methods (they don't call on each other).

[pmgreen]

Ok, I wasn't sure whether validate_marc was the method in record_level.rb or whether it was the logical structure for tests.

[Beck-Davis]

I double checked, it looks like we've been creating separate files for each method to be tested, even if the method is smaller, unless they are directly related or one calls the other. So for this one, it can have its own file.

[pmgreen]

The invalid_tag? method is currently only checking for non-numeric characters within a tag (not length, etc.). Maybe rename it to non_numeric_tag?.

[Beck-Davis]

looks good

[Beck-Davis]

looks good

[Beck-Davis]

The invalid_tag? method is currently only checking for non-numeric characters within a tag (not length, etc.). Maybe rename it to non_numeric_tag?.

True. We can make a ticket for it.