new fixture for issue 63 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by Peter Green <pmgreen@users.noreply.github.com>
|
I would like to have the test included in this pull request along with the fixture. So you can make additional commits within the same branch to write the test to accompany the fixture. |
mzelesky
reviewed
Nov 9, 2023
| <record> | ||
| <leader>01104nma a2200289 i 4500</leader> | ||
| <controlfield tag="001">99127156537506421</controlfield> | ||
| <controlfield tag="008">230519s1996 njua k 000 0 eng d</controlfield> |
There was a problem hiding this comment.
I would like to have the 008 have a value that can be fixed. In the fix_comp_008 method, that means that it has to be one of the following positions of the field:
audience (position 22 of u or v becomes j)
government publication indicator (position 28 of 'n' becomes 'o')
Co-authored-by: Tyler Wade <twade968@users.noreply.github.com>
|
The Fixture is updated and test created |
mzelesky
requested changes
Nov 20, 2023
* implement coveralls Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> * updated circleci config to run coveralls for rspec Co-authored-by: Bess Sadler <bess@users.noreply.github.com> --------- Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com> Co-authored-by: Bess Sadler <bess@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63.
Co-authored by Peter Green pmgreen@users.noreply.github.com