Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and fixture for book_008 method #71

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Test and fixture for book_008 method #71

merged 1 commit into from
Nov 27, 2023

Conversation

Beck-Davis
Copy link
Contributor

Closes #61

@Beck-Davis Beck-Davis self-assigned this Nov 22, 2023
@Beck-Davis Beck-Davis requested a review from mzelesky November 22, 2023 18:01
mzelesky
mzelesky approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@mzelesky mzelesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would like all 008 tests to be in one spec file, but I will do that in a separate PR.

@mzelesky mzelesky merged commit a7a9979 into main Nov 27, 2023
@mzelesky mzelesky deleted the i61_book_008 branch November 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzelesky mzelesky mzelesky approved these changes

Assignees

@Beck-Davis Beck-Davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make test for book format for bad_008?
2 participants
@Beck-Davis @mzelesky