Facet suggest: filtering facets, choosing a value, then attempting to filter again does not work

[sandbergja]

Thanks to @caroldh for identifying and reporting this issue!

Expected behavior

You can filter facets, choose a value, then filter again.

Actual behavior

You can only do it once, and then the UI breaks :-(

Steps to replicate

1. Search catalog.princeton.edu for economic policy
2. In the Language facet, click "more"
3. Filter the languages to "russ"
4. Select Russian
5. Note that your URL contains only_values=true and query_fragment=russ
6. In the Language facet, click "more" again
7. Note that you don't get a filter, or really much content in the modal at all!
   

Impact of this bug

Makes it hard to use facets to limit your search

Implementation notes, if any

• The search results page url should not contain only_values=true or query_fragment=russ -- these are only meant to be sent in the javascript fetch
• See upstream bug Facet suggest: filtering facets, choosing a value, then attempting to filter again does not work projectblacklight/blacklight#3507

[maxkadel]

Open PR against Blacklight main to fix this bug. Once that is approved and merged, we will then need to port the fix back to the release-8.x branch, do a Blacklight 8 release, and update Orangelight to use the newest version of Blacklight 8

[maxkadel]

PR against Blacklight main has been merged, now have and open PR against release-8.x branch

[maxkadel]

Closed by #4736