Implementing date-based sorting for call numbers in the browse lists #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
changed the title
|
This should have extended test coverage and better code documentation. |
|
@jrgriffiniii would you consider adding this functionality to the lcsort gem? https://github.com/pulibrary/lcsort |
jrgriffiniii
force-pushed
the
issues-1341-jrgriffiniii-lc-call-number-sort
branch
from
92e7f31 to
29c4407
Compare
|
@tampakis I'll proceed by working to resolve this on pulibrary/lcsort#14 |
jrgriffiniii
force-pushed
the
issues-1341-jrgriffiniii-lc-call-number-sort
branch
from
29c4407 to
590f54e
Compare
jrgriffiniii
changed the title
|
Closed in response to pulibrary/lcsort#15 and #1367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1341