Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vale to CircleCI for linting documentation #4046

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ orbs:
browser-tools: circleci/browser-tools@1.4.8
ruby: circleci/ruby@2.1.4
node: circleci/node@5.3.0
browser-tools: circleci/browser-tools@1.4.6
vale: circleci/vale@1.0.0
executors:
orangelight-executor:
docker:
Expand Down Expand Up @@ -225,6 +227,8 @@ workflows:
- test:
requires:
- build
- vale/lint
config: docs/.vale.ini
- finish:
requires:
- test
Expand Down
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,16 @@ It will tell you if you've passed the assertion(s) specified
in `lighthouserc.js`. It will also give you a URL where you
can see the complete lighthouse results.

#### Documentation linting with vale

To run locally:
```
brew install vale
cd docs
vale sync
vale .
```

#### Running CodeQL locally

If you get a CodeQL warning on your branch, you may wish to run
Expand Down
11 changes: 11 additions & 0 deletions docs/.vale.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
StylesPath = .vale

MinAlertLevel = suggestion

Packages = RedHat

Vocab = Base

[*]
BasedOnStyles = Vale, RedHat

12 changes: 12 additions & 0 deletions docs/.vale/config/vocabularies/Base/accept.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Ctrl
figgy
Figgy
iiif
Marquand
Mudd
orangelight
Orangelight
postgres
solr
Solr
tmux
2 changes: 1 addition & 1 deletion docs/browse-lists.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Fix:
- Find which machine to use from section: `How to know which machine to use`. Currently the `call_numbers` task is deployed to run on `catalog-indexer3`.
- SSH as `deploy` user to the machine used to produce the subjects lists

- Run the first rake task to generate the CSV file from solr data:
- Run the first rake task to generate the CSV file from Solr data:
- `cd /opt/orangelight/current`
- `OL_DB_PORT=5432 bundle exec rake browse:subjects`

Expand Down
Loading