Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bibdata-staging.princeton.edu to bibdata-staging.lib.princeton.edu #4354

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

christinach
Copy link
Member

Rename bibdata-staging.princeton.edu to bibdata-staging.lib.princeton.edu

Bibdata staging is on adc-dev and using the .lib

Copy link
Contributor

@maxkadel maxkadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christinach! 🐬

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 96.474%. remained the same
when pulling 39f142e on rename-bibdata-staging
into 9278ef8 on main.

@christinach christinach force-pushed the rename-bibdata-staging branch 3 times, most recently from b747615 to 2540106 Compare September 17, 2024 22:29
@christinach
Copy link
Member Author

christinach commented Sep 18, 2024

Lighthouse is failing with the following error on Circleci. It works locally. Probably related to the bibdata-staging.lib domain in adc-dev or the private IP:

Running Lighthouse 3 time(s) on http://localhost:2999/catalog/99122304923506421
Run #1...failed!
Error: Lighthouse failed with exit code 1
    at ChildProcess.<anonymous> (/home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/src/collect/node-runner.js:120:21)
    at ChildProcess.emit (node:events:517:28)
    at ChildProcess._handle.onexit (node:internal/child_process:292:12)
{
  "lighthouseVersion": "12.1.0",
  "requestedUrl": "http://localhost:2999/catalog/99122304923506421",
  "mainDocumentUrl": "http://localhost:2999/catalog/99122304923506421",
  "finalDisplayedUrl": "http://localhost:2999/catalog/99122304923506421",
  "finalUrl": "http://localhost:2999/catalog/99122304923506421",
  "fetchTime": "2024-09-17T22:33:51.077Z",
  "gatherMode": "navigation",
  "runtimeError": {
    "code": "ERRORED_DOCUMENT_REQUEST",
    "message": "Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 500)"
  },
  "runWarnings": [
    "Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 500)"
  ],
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/129.0.0.0 Safari/537.36",
  "environment": {
    "hostUserAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/129.0.0.0 Safari/537.36",
    "benchmarkIndex": 1699,
    "credits": {}
  },
  "audits": {
    "is-on-https": {
      "id": "is-on-https",
      "title": "Uses HTTPS",
      "description": "All sites should be protected with HTTPS, even ones that don't handle sensitive data. This includes avoiding [mixed content](https://developers.google.com/web/fundamentals/security/prevent-mixed-content/what-is-mixed-content), where some resources are loaded over HTTP despite the initial request being served over HTTPS. HTTPS prevents intruders from tampering with or passively listening in on the communications between your app and your users, and is a prerequisite for HTTP/2 and many new web platform APIs. [Learn more about HTTPS](https://developer.chrome.com/docs/lighthouse/pwa/is-on-https/).",
      "score": null,
      "scoreDisplayMode": "error",
      "errorMessage": "Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 500)",
      "errorStack": "LighthouseError: ERRORED_DOCUMENT_REQUEST\n    at getNetworkError (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/lib/navigation-error.js:61:14)\n    at getPageLoadError (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/lib/navigation-error.js:162:24)\n    at _computeNavigationResult (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/gather/navigation-runner.js:146:7)\n    at async gatherFn (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/gather/navigation-runner.js:300:23)\n    at async Runner.gather (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/runner.js:210:25)\n    at async navigationGather (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/gather/navigation-runner.js:306:21)\n    at async navigation (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/core/index.js:58:24)\n    at async runLighthouse (file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/cli/run.js:210:26)\n    at async file:///home/circleci/.nvm/versions/node/v18.19.1/lib/node_modules/@lhci/cli/node_modules/lighthouse/cli/index.js:10:1"
    },
    "redirects-http": {
      "id": "redirects-http",
      "title": "Redirects HTTP traffic to HTTPS",
      "description": "Make sure that you redirect all HTTP traffic to HTTPS in order to enable secure web features for all your users. [Learn more](https://developer.chrome.com/docs/lighthouse/pwa/redirects-http/).",
  

@christinach
Copy link
Member Author

christinach commented Sep 18, 2024

@sandbergja noticed that the rails server delayed to start so I added a wait for this port 2999 (run: dockerize -wait tcp://localhost:2999 -timeout 1m) but it still refuses to connect

2024/09/18 14:23:40 Waiting for: tcp://localhost:2999
2024/09/18 14:23:40 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s
2024/09/18 14:23:41 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s
2024/09/18 14:23:42 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s
2024/09/18 14:23:43 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s
2024/09/18 14:23:44 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s
2024/09/18 14:23:45 Problem with dial: dial tcp 127.0.0.1:2999: connect: connection refused. Sleeping 1s

@christinach
Copy link
Member Author

Created #4359 as a follow up ticket to put back Lighthouse in CI.

@christinach christinach merged commit 51df457 into main Sep 18, 2024
11 checks passed
@christinach christinach deleted the rename-bibdata-staging branch September 18, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants