Skip to content

Commit

Permalink
Do not show file download table when there are no files
Browse files Browse the repository at this point in the history 
But still display the Globus download button if globus downloads are
possible.
  • Loading branch information
@bess
bess committed Mar 15, 2022
1 parent 126e682 commit c19cceb
Show file tree
Hide file tree
Showing 4 changed files with 179 additions and 31 deletions.
8 changes: 8 additions & 0 deletions app/helpers/application_helper.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,14 @@ def render_globus_download(uri, item_id)
html.html_safe
end

def render_empty_files
html = <<-HTML
<div id="no_files">
</div>
HTML
html.html_safe
end

def authors_search_results_helper(field)
field[:value].join("; ")
end
Expand Down
72 changes: 41 additions & 31 deletions app/views/catalog/_show_documents.html.erb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,48 @@
<div class="lux">
<div class="card">
<div class="document-downloads card-body">
<table id="files-table" class="table">
<thead>
<tr>
<th scope="col" nowrap="nowrap"><span>#</span></th>
<th scope="col" nowrap="nowrap"><span>Filename</span></th>
<th scope="col"><span>Description</span></th>
<th scope="col" nowrap="nowrap"><span>Filesize</span></th>
</tr>
</thead>
<tbody>
<% @document.files.each_with_index do |file, ix| %>
<tr class="document-download">
<th scope="row">
<span><span><%= ix + 1 %></span></span>
</th>
<td>
<span>
<i class="bi bi-file-arrow-down"></i>
<a href="<%= file.download_url %>" class="documents-file-link" target="_blank" title="<%= file.name %>"><%= truncate(file.name, length: 60) %></a>
</span>
</td>
<td>
<span><%= file.description %></span>
</td>
<td>
<span><span><%= number_to_human_size(file.size) %></span></span>
</td>

<!-- Only render file download table if there are files in DataSpace -->

<% if @document.files.empty? %>
<%= render_empty_files %>
<% else %>
<table id="files-table" class="table">
<thead>
<tr>
<th scope="col" nowrap="nowrap"><span>#</span></th>
<th scope="col" nowrap="nowrap"><span>Filename</span></th>
<th scope="col"><span>Description</span></th>
<th scope="col" nowrap="nowrap"><span>Filesize</span></th>
</tr>
<% end %>
</tbody>
<tfoot></tfoot>
</table>
</thead>
<tbody>
<% @document.files.each_with_index do |file, ix| %>
<tr class="document-download">
<th scope="row">
<span><span><%= ix + 1 %></span></span>
</th>
<td>
<span>
<i class="bi bi-file-arrow-down"></i>
<a href="<%= file.download_url %>" class="documents-file-link" target="_blank" title="<%= file.name %>"><%= truncate(file.name, length: 60) %></a>
</span>
</td>
<td>
<span><%= file.description %></span>
</td>
<td>
<span><span><%= number_to_human_size(file.size) %></span></span>
</td>
</tr>
<% end %>
</tbody>
<tfoot></tfoot>
</table>
<% end %>

<!-- End of file download table -->

<%= render_globus_download(@document.globus_uri, @document.id) %>
</div>
</div>
Expand Down
122 changes: 122 additions & 0 deletions spec/fixtures/globus_items.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -318,4 +318,126 @@
</parentCommunityList>
<withdrawn>false</withdrawn>
</item>

<!-- Fake Item to Test an Object with Files only in Globus -->
<item>
<handle>88435/000111000</handle>
<id>101010</id>
<name>Object With Huge Files Only Available Via Globus</name>
<type>item</type>
<archived>true</archived>
<lastModified>2020-12-09 21:39:02.118</lastModified>
<metadata>
<key>dc.contributor.author</key>
<value>Bejjanki, Vikranth R.</value>
</metadata>
<metadata>
<key>dc.contributor.author</key>
<value>da Silveira, Rava Azeredo</value>
</metadata>
<metadata>
<key>dc.contributor.author</key>
<value>Cohen, Jonathan D.</value>
</metadata>
<metadata>
<key>dc.contributor.author</key>
<value>Turk-Browne, Nicholas B.</value>
</metadata>
<metadata>
<key>dc.date.accessioned</key>
<value>2017-08-10T18:42:18Z</value>
</metadata>
<metadata>
<key>dc.date.available</key>
<value>2017-08-10T18:42:18Z</value>
</metadata>
<metadata>
<key>dc.date.issued</key>
<value>2017-08</value>
</metadata>
<metadata>
<key>dc.identifier.uri</key>
<value>http://arks.princeton.edu/ark:/88435/dsp01dn39x4181</value>
</metadata>
<metadata>
<key>dc.identifier.uri</key>
<value>https://app.globus.org/file-manager?origin_id=dc43f461-0ca7-4203-848c-33a9fc00a464&origin_path=%2F9a07-f696%2F</value>
</metadata>
<metadata>
<key>dc.description</key>
<language>en_US</language>
<value>fMRI data used to carry out the analyses described in: Vikranth R. Bejjanki, Rava Azeredo da Silveira, Jonathan D. Cohen, & Nicholas B. Turk-Browne, "Noise correlations in the human brain and their impact on pattern classification". Includes data from 17 human participants, acquired with a 3T scanner (Siemens Skyra) using a 16-channel head coil. For each participant, data from two face/scene "localizer" runs, where participants were presented with blocks of face or scene stimuli interleaved with blank periods, and two "rest" runs, where participants passively viewed a central fixation point, is included. Further information is available in the dataset README file. This dataset is too large to download directly from this item page. You can access and download the data via Globus at this link: https://app.globus.org/file-manager?origin_id=dc43f461-0ca7-4203-848c-33a9fc00a464&origin_path=%2F9a07-f696%2F (See https://docs.globus.org/how-to/get-started/ for instructions on how to use Globus, sign-in is required).</value>
</metadata>
<metadata>
<key>dc.description.abstract</key>
<language>en_US</language>
<value>Multivariate decoding methods, such as multivoxel pattern analysis (MVPA), are highly effective at extracting information from brain imaging data. Yet, the precise nature of the information that MVPA draws upon remains controversial. Most current theories emphasize the enhanced sensitivity imparted by aggregating across voxels that have mixed and weak selectivity. However, beyond the selectivity of individual voxels, neural variability is correlated across voxels, and such noise correlations may contribute importantly to accurate decoding. Indeed, a recent computational theory proposed that noise correlations enhance multivariate decoding from heterogeneous neural populations. Here we extend this theory from the scale of neurons to functional magnetic resonance imaging (fMRI) and show that noise correlations between heterogeneous populations of voxels (i.e., voxels selective for different stimulus variables) contribute to the success of MVPA. Specifically, decoding performance is enhanced when voxels with high vs. low noise correlations (measured during rest or in the background of the task) are selected during classifier training. Conversely, voxels that are strongly selective for one class in a GLM or that receive high classification weights in MVPA tend to exhibit high noise correlations with voxels selective for the other class being discriminated against. Furthermore, we use simulations to show that this is a general property of fMRI data and that selectivity and noise correlations can have distinguishable influences on decoding. Taken together, our findings demonstrate that if there is signal in the data, the resulting above-chance classification accuracy is modulated by the magnitude of noise correlations.</value>
</metadata>
<metadata>
<key>dc.title</key>
<language>en_US</language>
<value>Noise correlations in the human brain and their impact on pattern classification</value>
</metadata>
<metadata>
<key>dc.type</key>
<language>en_US</language>
<value>Dataset</value>
</metadata>
<metadata>
<key>pu.projectgrantnumber</key>
<value>PRINU-24400-G0002-10005089-101</value>
</metadata>
<parentCollection>
<expand>parentCommunityList</expand>
<expand>parentCommunity</expand>
<expand>items</expand>
<expand>license</expand>
<expand>logo</expand>
<expand>all</expand>
<handle>88435/dsp010g354h44r</handle>
<id>1061</id>
<name>Research Data Sets</name>
<type>collection</type>
<copyrightText/>
<introductoryText/>
<numberItems>28</numberItems>
<shortDescription/>
<sidebarText/>
</parentCollection>
<parentCollectionList>
<expand>parentCommunityList</expand>
<expand>parentCommunity</expand>
<expand>items</expand>
<expand>license</expand>
<expand>logo</expand>
<expand>all</expand>
<handle>88435/dsp010g354h44r</handle>
<id>1061</id>
<name>Research Data Sets</name>
<type>collection</type>
<copyrightText/>
<introductoryText/>
<numberItems>28</numberItems>
<shortDescription/>
<sidebarText/>
</parentCollectionList>
<parentCommunityList>
<expand>parentCommunity</expand>
<expand>collections</expand>
<expand>subCommunities</expand>
<expand>logo</expand>
<expand>all</expand>
<handle>88435/dsp0147429c369</handle>
<id>326</id>
<name>Princeton Neuroscience Institute</name>
<type>community</type>
<copyrightText/>
<countItems>28</countItems>
<introductoryText/>
<shortDescription/>
<sidebarText/>
</parentCommunityList>
<withdrawn>false</withdrawn>
</item>

</items>
8 changes: 8 additions & 0 deletions spec/system/globus_item_metadata_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,12 @@
visit '/catalog/6517'
expect(page).not_to have_content "Download from Globus"
end

context "when there are no files in DataSpace" do
it "displays the Globus button but not the file listing" do
visit '/catalog/101010'
expect(page).to have_content "Download from Globus"
expect(page).not_to have_content "Showing 0 to 0 of 0 entries"
end
end
end

0 comments on commit c19cceb

Please sign in to comment.