Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When we deploy, the footer sometimes has stale data #97

Closed
bess opened this issue Nov 29, 2021 · 0 comments · Fixed by #112
Closed

Bug: When we deploy, the footer sometimes has stale data #97

bess opened this issue Nov 29, 2021 · 0 comments · Fixed by #112
Assignees

Comments

@bess
Copy link
Contributor

bess commented Nov 29, 2021

Problem: We are currently needing to deploy pdc_discovery twice in order to get the right info printed to the screen.

The version info on the screen gets read in via an initializer (https://github.com/pulibrary/pdc_discovery/blob/main/config/initializers/git_sha.rb). Because it is an initializer, it is only read one time, at application startup. The problem is that the application appears to be restarting before that file is completely written.

I believe this would be fixed by forcing the application to restart again, after the entire deploy is complete. This would add to deploy restart time, but I think it would be worth it to enable users to see for themselves what version of the software is deployed and to be able to trust that the info is correct. There might also be other solutions I haven't thought of.

Version info in the footer of the application:
Screen Shot 2021-11-29 at 11 25 05 AM

Tail of deploy@pdc-discovery-staging1:/opt/pdc_discovery/revisions.log:
Screen Shot 2021-11-29 at 11 23 38 AM

@bess bess added the bug label Nov 29, 2021
@hectorcorrea hectorcorrea changed the title Bug: When we deploy, the footer sometimes has state data Bug: When we deploy, the footer sometimes has stale data Nov 29, 2021
@hectorcorrea hectorcorrea self-assigned this Dec 3, 2021
@bess bess closed this as completed in #112 Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants