Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version footer #112

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Version footer #112

merged 4 commits into from
Dec 8, 2021

Conversation

hectorcorrea
Copy link
Member

@hectorcorrea hectorcorrea commented Dec 6, 2021

Gets version information from Capistrano files and detects when it's stale. When the version is stale we don't cache the information and we indicate in the display that the information is in fact stale.

The code will read the Capistrano file as long as the information is stale. Once the version information is current (i.e. not stale) we cache it and don't read the Capistrano file again. This should allow the system to display current information within a pageview or two after Capistrano has updated the revisions.log file.

Fixes #97

@hectorcorrea hectorcorrea mentioned this pull request Dec 7, 2021
@pulbot pulbot temporarily deployed to staging December 8, 2021 16:08 Inactive
@pulbot pulbot temporarily deployed to staging December 8, 2021 16:11 Inactive
@hectorcorrea hectorcorrea force-pushed the issue-67-version-redux branch from c8cb284 to c51b681 Compare December 8, 2021 17:15
@hectorcorrea hectorcorrea changed the title Issue 67 version (another attempt) Version footer Dec 8, 2021
@hectorcorrea hectorcorrea marked this pull request as ready for review December 8, 2021 17:34
Copy link
Contributor

@bess bess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bess bess merged commit 8b90929 into main Dec 8, 2021
@bess bess deleted the issue-67-version-redux branch December 8, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When we deploy, the footer sometimes has stale data
3 participants