Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Dataspace URL #111

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Configurable Dataspace URL #111

merged 1 commit into from
Dec 7, 2021

Conversation

hectorcorrea
Copy link
Member

Replaces hard-coded URL for Dataspace with config value defined in pdc_discovery.yml

Fixes #49

kelynch
kelynch approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@kelynch kelynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great.

@kelynch kelynch merged commit 4d92e10 into main Dec 7, 2021
@kelynch kelynch deleted the issue-49-dataspace-instances branch December 7, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelynch kelynch kelynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-staging and -prod should index different dataspace instances
2 participants
@hectorcorrea @kelynch