Re-think our solr config #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In attempting to implement the solr changes needed for blacklight_dynamic_sitemap, I encountered regular stack overflow errors in the logs. I hypothesize that these are contributing to my difficulty in adding new solr configuration changes. This PR updates solrconfig to compatibility with Solr 8 (to match what we're running in production) and strips out un-used stanzas. Now all the tests pass and I am no longer seeing fatal errors in our logs. I'd like to promote these changes to production, ensure everything is still working as expected, and then try to implement the sitemap changes again.
| @@ -1,27 +1,26 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
Sorry, but just for my own understanding, why was the encoding removed? Is this explicitly defined elsewhere for Solr as the default?
jrgriffiniii
approved these changes
Feb 17, 2022
|
Thank you very much for this @bess! I am hesitant to merge this until testing this on |
hectorcorrea
approved these changes
Feb 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempting to implement the solr changes needed for
blacklight_dynamic_sitemap, I encountered regular stack overflow errors
in the logs. I hypothesize that these are contributing to my difficulty
in adding new solr configuration changes. This PR updates solrconfig to
compatibility with Solr 8 (to match what we're running in production)
and strips out un-used stanzas. Now all the tests pass and I am no
longer seeing fatal errors in our logs. I'd like to promote these
changes to production, ensure everything is still working as expected,
and then try to implement the sitemap changes again.
Work toward #72