Rearranged facets #170
Merged
Rearranged facets #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
commented
Feb 22, 2022
| config.add_facet_field 'community_root_name_ssi', label: 'Community' | ||
| config.add_facet_field 'subcommunity_name_ssi', label: 'Subcommunity' | ||
| config.add_facet_field 'collection_name_ssi', label: 'Collection' | ||
| config.add_facet_field 'author_ssim', label: 'Author', limit: true |
There was a problem hiding this comment.
limit:true is what allows Blacklight to display the "more" value in the facet list that opens the pop-up window to view all facet values.
hectorcorrea
commented
Feb 22, 2022
Comment on lines
+82
to
+85
| // Hide the subcommunity facet unless we are faceting by community or subcommunity. | ||
| if (!activeFacet("community_root_name_ssi") && !activeFacet("subcommunity_name_ssi")) { | ||
| hideFacetGroup("subcommunity_name_ssi"); | ||
| } |
There was a problem hiding this comment.
This is the code that hides the subcommunity facet unless it's relevant.
There was a problem hiding this comment.
I love that you left a comment about where the inspiration for this came from. Very useful for long-term maintenance and kind to your colleagues!
bess
approved these changes
Feb 23, 2022
Comment on lines
+82
to
+85
| // Hide the subcommunity facet unless we are faceting by community or subcommunity. | ||
| if (!activeFacet("community_root_name_ssi") && !activeFacet("subcommunity_name_ssi")) { | ||
| hideFacetGroup("subcommunity_name_ssi"); | ||
| } |
There was a problem hiding this comment.
I love that you left a comment about where the inspiration for this came from. Very useful for long-term maintenance and kind to your colleagues!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the order in which facets are displayed as requested in #161 and included the proper Blacklight configuration to allow the user to view "more" facet values when there are more than 10. I also fixed a problem with Author facet that was using a non-existing field.
Notice that the Subcommunity facet displays only when (1) the user filters by community and the community has subcommunities (in practice this means it only shows when the community is PPPL)
Closes #161