Upgrade to Rails 7.2 so we can stay current with security patches #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
@bess looks good. One comment, but I think we could move forward with this PR.
| @@ -35,8 +35,10 @@ | |||
| end | |||
| RSpec.configure do |config| | |||
| config.include Rails.application.routes.url_helpers | |||
| # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures | |||
| config.fixture_path = Rails.root.join('spec', 'fixtures').to_s | |||
|
|
|||
There was a problem hiding this comment.
@bess I wonder if this is really needed. I didn't have this change in describe. I think spec/fixtures is the default. Not that being specific is necessarily bad...
There was a problem hiding this comment.
Convo had in slack https://pulibrary.slack.com/archives/C02PHG9MGU8/p1727444106734649?thread_ts=1727441984.978499&cid=C02PHG9MGU8 This IS needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #681