Add in a retry for urls that do not succeed #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolyncole
force-pushed
the
timeout-up
branch
from
f891237 to
56408d6
Compare
carolyncole
changed the title
Adding an open timeout and upping the read timeout
carolyncole
force-pushed
the
timeout-up
branch
from
56408d6 to
f4b7d39
Compare
|
|
||
| # retry an errored urls a second time and send error only if they don't work a second time | ||
| urls_to_retry.each do |url| | ||
| process_url(url) | ||
| rescue => ex | ||
| Rails.logger.warn "Error importing record from #{url}. Exception: #{ex.message}" | ||
| Honeybadger.notify "Error importing record from #{url}. Exception: #{ex.message}" |
jrgriffiniii
approved these changes
Oct 17, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an open timeout and upping the read timeout