Load file list on the background on the Show page #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claudia Lee <claudiawulee@users.noreply.github.com>
…he DataTables JavaScript to display and sort correctly. Co-authored-by: Claudia Lee <claudiawulee@users.noreply.github.com>
Co-authored-by: Claudia Lee <claudiawulee@users.noreply.github.com>
hectorcorrea
changed the title
hectorcorrea
commented
Nov 14, 2024
| <% end %> | ||
| <th scope="col" nowrap="nowrap"><span>Filesize</span></th> | ||
| <th>Filename</th> | ||
| <th>Size</th> | ||
| </tr> |
There was a problem hiding this comment.
We ditched the columns with the sequence number and the description for each file since we don't show those in PDC Describe. (Plus we don't have file description in PDC Describe, this was for DataSpace records but we are moving away from that)
hectorcorrea
commented
Nov 14, 2024
| @@ -63,8 +32,45 @@ | |||
| <script type="text/javascript"> | |||
| $(function() { | |||
|
|
|||
| // Wire DataTable for the file list. | |||
| $('#files-table').DataTable(); | |||
| $('#files-table').DataTable({ | |||
There was a problem hiding this comment.
We stole most of the DataTables configuration from PDC Describe: https://github.com/pulibrary/pdc_describe/blob/main/app/views/works/_s3_resources.html.erb#L74
bess
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load the file list on the background via AJAX so the page with the metadata renders immediately to the user.
Co-authored-by: Claudia Lee claudiawulee@users.noreply.github.com
Closes #709