Adjust Error Handling for the All Search API #4396
Assignees
Milestone
Comments
|
related to pulibrary/allsearch_api#126 |
|
Jane will check in with operations on how this change fits in with wider Ansible template re-factor. |
|
We should wait to adjust the error handling until the allsearch_api nginx config is generated by an ansible template (#4397 ) |
sandbergja
added a commit
that referenced
this issue
Jun 28, 2024
This allows 400 and 500 JSON responses through from the application, and returns other errors in JSON format, rather than the standard "Something went wrong" html page. Closes #4396 For background information on why we'd like to offer JSON errors, see https://github.com/pulibrary/allsearch_api/blob/main/architecture-decisions/001_error_output.md
sandbergja
added a commit
that referenced
this issue
Jun 28, 2024
This allows 400 and 500 JSON responses through from the application, and returns other errors in JSON format, rather than the standard "Something went wrong" html page. Closes #4396 For background information on why we'd like to offer JSON errors, see https://github.com/pulibrary/allsearch_api/blob/main/architecture-decisions/001_error_output.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The allsearch api returns 400s with useful JSON data when an empty query is passed, and 500s if it encounters an error, but in both cases, it returns the generic PUL error page (see, e.g., https://allsearch-api.princeton.edu/search/catalog?query=). This may be an issue of needing to change behavior on the load balancer (in the Princeton Ansible NGINX config, probably something to do with the errors.conf template). We'd like to return a meaningful error message to client applications.
The text was updated successfully, but these errors were encountered: